[jira] Commented: (SHINDIG-415) Missing flushBuffer() in ConcatProxyServlet

["Paul Lindner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627831#action_12627831 ] 

Paul Lindner commented on SHINDIG-415:
--------------------------------------

What servlet container are you using?

You should not need to call flushBuffer()

http://java.sun.com/products/servlet/download.html

has:

5.5 Closure of Response Object

     A number of events can indicate that the servlet has
     provided all of the content to satisfy the request and
     that the response object can be considered to be closed.

     The events are:

       - The termination of the service method of the servlet.
       - When the amount of content specified in the
         setContentLength method of the response has been
         written to the response.
       - The sendError method is called.
       - The sendRedirect method is called.

     When a response is closed, all content in the response
     buffer, if any remains, must be immediately flushed to
     the client.


> Missing flushBuffer() in ConcatProxyServlet
> -------------------------------------------
>
>                 Key: SHINDIG-415
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-415
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (Java)
>         Environment: all
>            Reporter: christof kaleschke
>            Assignee: Paul Lindner
>
> The ConcatProxyServlet doesn't call wrapper.flushBuffer(); at any time. That causes the behavior that files (eg. JavaScript files) are fetched from others servers but are not transferred to the browser.
> I had the case that a JavaScript file was fetched from another server (I could see that in the network monitor) by ProxyHandler.fetch(), but the response transferred to the browser was empty.
> When I added wrapper.flushBuffer(); just before response.setStatus(200); in the ConcatProxyServlet.doGet() the JavaScript was transferred correctly.
> One might think of adding flushBuffer() in the other Servlets as well :-) 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.