You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/14 11:05:40 UTC
[GitHub] [ignite] ymolochkov opened a new pull request #8665: IGNITE-13949 improved concurrent behaviour in PartitionUpdateCounterT…
ymolochkov opened a new pull request #8665:
URL: https://github.com/apache/ignite/pull/8665
Substituted AtomicLong's for volatile long for several reasons:
- I think it's not worth it to have almost the same visibility benefits with AtomicLong's and create unnecessary objects for them. Native locks and volatile fields should be sufficient here;
- almost everywhere there are compound actions which require a separate synchronisation for themselves to be atomic, so AtomicLong's are overkill.
Also added necessary synchronisation in toString, copy and some other methods, since they we have reads over mutable variables.
Making iterator method synchronised is pointless, call to the iterator should be synced externally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ymolochkov closed pull request #8665: IGNITE-13949 improved concurrent behaviour in PartitionUpdateCounterT…
Posted by GitBox <gi...@apache.org>.
ymolochkov closed pull request #8665:
URL: https://github.com/apache/ignite/pull/8665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org