[GitHub] [geode] nabarunnag opened pull request #2813: GEODE-6014: Removed unnecessary null checks.

["nabarunnag (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["mcmellawatt (GitHub)" <gi...@apache.org>]

Can we just delete this commented out code?

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["nabarunnag (GitHub)" <gi...@apache.org>]

I made a mistake... 
Used the intelliJ auto-correct.
--fixed

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag closed pull request #2813: GEODE-6014: Removed unnecessary null checks.

["nabarunnag (GitHub)" <gi...@apache.org>]

[ pull request closed by nabarunnag ]

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["bschuchardt (GitHub)" <gi...@apache.org>]

I think you can remove this if statement.  We've already checked if locators.isEmpty() earlier in the method.

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["mcmellawatt (GitHub)" <gi...@apache.org>]

Extra newline here maybe?

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["bschuchardt (GitHub)" <gi...@apache.org>]

Why is it okay to delete the assignment (s.right = pr)?

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["bschuchardt (GitHub)" <gi...@apache.org>]

Why is it okay to delete the assignment (s.left = pl)?

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["nabarunnag (GitHub)" <gi...@apache.org>]

done

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["nabarunnag (GitHub)" <gi...@apache.org>]

fixed

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on issue #2813: GEODE-6014: Removed unnecessary null checks.

["nabarunnag (GitHub)" <gi...@apache.org>]

@mcmellawatt These were initially flagged by LGTM, but they were reviewed in the code. If you load the diff using an IDE you can see the reason why these values can't be null

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #2813: GEODE-6014: Removed unnecessary null checks.

["bschuchardt (GitHub)" <gi...@apache.org>]

It looks like you can delete these variables

[ Full content available at: https://github.com/apache/geode/pull/2813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org