You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/05 08:38:29 UTC
[GitHub] [flink] dawidwys opened a new pull request #11993: [FLINK-17313] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
dawidwys opened a new pull request #11993:
URL: https://github.com/apache/flink/pull/11993
This is a backport of aed8c1957a706c35d824c598e2d610d897059c36 (#11848). Because
the method LogicalTypeCasts#supportsAvoidingCast was only introduced in
1.11. This commit extracts the necessary logic for comparing
char/varchar/binary/varbinary of different length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623929921
cc @zjuwangg @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623937740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44684cf21830a610d27f475332e4f007cd86e960",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44684cf21830a610d27f475332e4f007cd86e960",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44684cf21830a610d27f475332e4f007cd86e960 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623937740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44684cf21830a610d27f475332e4f007cd86e960",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163896547",
"triggerID" : "44684cf21830a610d27f475332e4f007cd86e960",
"triggerType" : "PUSH"
}, {
"hash" : "12862572ced0f194f059715ae348dc0d2b7f16f3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163984232",
"triggerID" : "12862572ced0f194f059715ae348dc0d2b7f16f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44684cf21830a610d27f475332e4f007cd86e960 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/163896547)
* 12862572ced0f194f059715ae348dc0d2b7f16f3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/163984232)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623937740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44684cf21830a610d27f475332e4f007cd86e960",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163896547",
"triggerID" : "44684cf21830a610d27f475332e4f007cd86e960",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44684cf21830a610d27f475332e4f007cd86e960 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/163896547)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623931193
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 44684cf21830a610d27f475332e4f007cd86e960 (Tue May 05 08:41:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623937740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44684cf21830a610d27f475332e4f007cd86e960",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163896547",
"triggerID" : "44684cf21830a610d27f475332e4f007cd86e960",
"triggerType" : "PUSH"
}, {
"hash" : "12862572ced0f194f059715ae348dc0d2b7f16f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12862572ced0f194f059715ae348dc0d2b7f16f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44684cf21830a610d27f475332e4f007cd86e960 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/163896547)
* 12862572ced0f194f059715ae348dc0d2b7f16f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11993: [FLINK-17313][bp-1.10] Fix type validation error when sink table ddl contains columns with precision of decimal/varchar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11993:
URL: https://github.com/apache/flink/pull/11993#issuecomment-623937740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44684cf21830a610d27f475332e4f007cd86e960",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163896547",
"triggerID" : "44684cf21830a610d27f475332e4f007cd86e960",
"triggerType" : "PUSH"
}, {
"hash" : "12862572ced0f194f059715ae348dc0d2b7f16f3",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163984232",
"triggerID" : "12862572ced0f194f059715ae348dc0d2b7f16f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12862572ced0f194f059715ae348dc0d2b7f16f3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/163984232)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org