You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2025/05/28 16:00:15 UTC
[PR] [fix](agg_state) Add new version of function map_agg [doris]
mrhhsg opened a new pull request, #51343:
URL: https://github.com/apache/doris/pull/51343
### What problem does this PR solve?
The old version of `map_agg` had issues handling null values and did not support null as a key.
The new version function `mag_agg_v2` support null as key and fixed the null value issues.
```
select k2, map_agg(v1, v2) m from `test_map_agg_2` group by k2;
+------+----------------------------------------+
| k2 | m |
+------+----------------------------------------+
| 6 | {null:null} |
| 3 | {null:"3", "c":"c"} |
| 1 | {"e":"f", "k":"j", "a":"b", "ee":"nn"} |
| 2 | {"a":"a2", null:"2", "b":"bddd"} |
+------+----------------------------------------+
```
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2917992921
<details>
<summary>TPC-H: <b>Total hot run time: 33977 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86163cd5082d6124d7bcb919a7024c918fad4574, data reload: false
------ Round 1 ----------------------------------
q1 26167 5038 5004 5004
q2 2083 310 193 193
q3 10352 1240 744 744
q4 10235 1030 515 515
q5 7569 2398 2314 2314
q6 185 175 139 139
q7 957 719 610 610
q8 9316 1264 1144 1144
q9 7078 5060 5108 5060
q10 6894 2322 1912 1912
q11 496 287 273 273
q12 349 358 215 215
q13 17797 3645 3099 3099
q14 236 242 216 216
q15 531 502 476 476
q16 410 434 378 378
q17 595 856 362 362
q18 7536 7217 7182 7182
q19 2940 1407 626 626
q20 324 340 211 211
q21 3615 2571 2344 2344
q22 1046 1035 960 960
Total cold run time: 116711 ms
Total hot run time: 33977 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5259 5088 5122 5088
q2 236 331 227 227
q3 2175 2611 2259 2259
q4 1447 1843 1469 1469
q5 4465 4395 4401 4395
q6 211 165 138 138
q7 2028 1941 1764 1764
q8 2600 2545 2534 2534
q9 7255 7133 7068 7068
q10 2987 3171 2779 2779
q11 574 525 509 509
q12 682 780 620 620
q13 3494 3862 3287 3287
q14 286 327 276 276
q15 522 474 477 474
q16 458 485 456 456
q17 1137 1533 1409 1409
q18 7727 7577 7387 7387
q19 824 841 954 841
q20 1970 2028 1840 1840
q21 4708 4592 4521 4521
q22 1083 1046 1054 1046
Total cold run time: 52128 ms
Total hot run time: 50387 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2921146331
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2917215693
<details>
<summary>TPC-DS: <b>Total hot run time: 192823 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1cd18b711587bd2f89a2d33af830143cf3959740, data reload: false
query1 1412 1099 1062 1062
query2 6315 1804 1829 1804
query3 11038 4653 4611 4611
query4 53554 25698 23479 23479
query5 5288 505 467 467
query6 412 213 203 203
query7 5163 509 304 304
query8 302 242 224 224
query9 6975 2583 2592 2583
query10 450 325 270 270
query11 15290 15014 14766 14766
query12 161 111 104 104
query13 1191 534 397 397
query14 10075 6306 6333 6306
query15 233 210 196 196
query16 7041 654 513 513
query17 1094 712 604 604
query18 1595 421 320 320
query19 214 200 181 181
query20 142 133 122 122
query21 205 129 110 110
query22 4333 4496 4356 4356
query23 34331 33772 33521 33521
query24 6567 2462 2459 2459
query25 469 474 417 417
query26 666 274 188 188
query27 2205 511 352 352
query28 2932 2181 2179 2179
query29 603 578 453 453
query30 278 232 192 192
query31 844 841 783 783
query32 74 61 63 61
query33 464 356 293 293
query34 782 867 544 544
query35 810 819 766 766
query36 935 1006 874 874
query37 117 107 87 87
query38 4361 4228 4145 4145
query39 1515 1478 1458 1458
query40 224 120 109 109
query41 68 60 57 57
query42 123 117 108 108
query43 509 512 483 483
query44 1397 864 848 848
query45 181 201 170 170
query46 868 1067 680 680
query47 1825 1855 1761 1761
query48 402 443 320 320
query49 673 495 403 403
query50 688 698 409 409
query51 4298 4318 4226 4226
query52 112 118 113 113
query53 239 264 186 186
query54 601 599 526 526
query55 90 88 87 87
query56 314 325 295 295
query57 1160 1213 1095 1095
query58 278 278 264 264
query59 2764 2773 2686 2686
query60 350 354 308 308
query61 130 130 134 130
query62 720 716 679 679
query63 229 191 190 190
query64 1467 1048 678 678
query65 4364 4236 4212 4212
query66 719 406 301 301
query67 15922 15778 15565 15565
query68 7169 891 582 582
query69 557 308 266 266
query70 1191 1140 1130 1130
query71 499 317 318 317
query72 5907 4757 4876 4757
query73 1211 633 363 363
query74 9045 9154 8683 8683
query75 3665 3213 2695 2695
query76 4269 1197 764 764
query77 618 363 283 283
query78 10135 10188 9304 9304
query79 2187 828 573 573
query80 648 506 451 451
query81 515 269 214 214
query82 433 125 94 94
query83 415 257 228 228
query84 296 117 83 83
query85 831 362 323 323
query86 400 296 282 282
query87 4382 4475 4293 4293
query88 3374 2298 2287 2287
query89 415 318 280 280
query90 1826 215 208 208
query91 138 148 115 115
query92 78 58 59 58
query93 1771 962 581 581
query94 665 413 295 295
query95 371 301 285 285
query96 486 571 275 275
query97 2721 2774 2624 2624
query98 226 203 208 203
query99 1419 1371 1284 1284
Total cold run time: 299014 ms
Total hot run time: 192823 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918478308
<details>
<summary>ClickBench: <b>Total hot run time: 29.11 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6deab91aa93935e57747c73d630d74751de7e2a7, data reload: false
query1 0.04 0.04 0.04
query2 0.13 0.11 0.10
query3 0.26 0.19 0.20
query4 1.59 0.19 0.10
query5 0.44 0.40 0.43
query6 1.16 0.66 0.67
query7 0.03 0.02 0.02
query8 0.04 0.04 0.04
query9 0.57 0.51 0.51
query10 0.56 0.57 0.56
query11 0.16 0.10 0.11
query12 0.15 0.11 0.12
query13 0.61 0.60 0.59
query14 0.79 0.79 0.82
query15 0.88 0.86 0.85
query16 0.38 0.38 0.38
query17 1.02 0.98 1.06
query18 0.22 0.20 0.21
query19 1.90 1.87 1.79
query20 0.01 0.02 0.02
query21 15.42 0.90 0.55
query22 0.77 1.17 0.62
query23 15.04 1.39 0.63
query24 6.80 1.35 0.91
query25 0.48 0.08 0.14
query26 0.69 0.17 0.15
query27 0.06 0.05 0.05
query28 10.09 0.94 0.43
query29 12.56 4.11 3.48
query30 0.26 0.10 0.08
query31 2.81 0.59 0.38
query32 3.24 0.55 0.48
query33 2.99 3.07 3.14
query34 15.73 5.08 4.45
query35 4.49 4.54 4.50
query36 0.66 0.50 0.49
query37 0.09 0.07 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.16 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.04 0.03
Total cold run time: 103.51 s
Total hot run time: 29.11 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2917185058
<details>
<summary>TPC-H: <b>Total hot run time: 33770 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1cd18b711587bd2f89a2d33af830143cf3959740, data reload: false
------ Round 1 ----------------------------------
q1 26343 5036 5027 5027
q2 2093 287 188 188
q3 10456 1213 673 673
q4 10240 1008 510 510
q5 8066 2409 2321 2321
q6 182 163 133 133
q7 922 716 614 614
q8 9306 1233 1158 1158
q9 6779 5134 4989 4989
q10 6897 2329 1899 1899
q11 509 298 270 270
q12 336 348 217 217
q13 17766 3754 3115 3115
q14 228 226 211 211
q15 534 479 491 479
q16 413 436 378 378
q17 600 872 362 362
q18 7668 7251 7138 7138
q19 1691 968 567 567
q20 343 335 217 217
q21 3691 2643 2322 2322
q22 1023 1023 982 982
Total cold run time: 116086 ms
Total hot run time: 33770 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5183 5088 5080 5080
q2 243 332 223 223
q3 2143 2680 2321 2321
q4 1347 1797 1335 1335
q5 4487 4346 4454 4346
q6 224 168 129 129
q7 2004 1958 1768 1768
q8 2597 2619 2617 2617
q9 7239 7225 6942 6942
q10 2995 3186 2758 2758
q11 596 530 490 490
q12 649 778 596 596
q13 3529 3872 3246 3246
q14 278 311 305 305
q15 547 480 496 480
q16 447 491 471 471
q17 1185 1583 1359 1359
q18 7788 7528 7427 7427
q19 843 840 933 840
q20 2050 2061 1889 1889
q21 4784 4450 4359 4359
q22 1074 1062 991 991
Total cold run time: 52232 ms
Total hot run time: 49972 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2916860266
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2916876334
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918044053
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #51343:
URL: https://github.com/apache/doris/pull/51343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918281944
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918444351
<details>
<summary>TPC-H: <b>Total hot run time: 33769 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6deab91aa93935e57747c73d630d74751de7e2a7, data reload: false
------ Round 1 ----------------------------------
q1 26270 5094 5024 5024
q2 1963 278 181 181
q3 10383 1266 684 684
q4 10231 992 520 520
q5 7605 2417 2295 2295
q6 183 165 135 135
q7 913 745 599 599
q8 9311 1289 1147 1147
q9 6817 5126 5086 5086
q10 6882 2305 1900 1900
q11 486 290 276 276
q12 338 346 221 221
q13 17761 3669 3091 3091
q14 230 223 222 222
q15 559 490 496 490
q16 427 432 373 373
q17 585 869 357 357
q18 7886 7169 7050 7050
q19 1671 979 566 566
q20 331 342 224 224
q21 3746 3149 2353 2353
q22 1064 1044 975 975
Total cold run time: 115642 ms
Total hot run time: 33769 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5167 5063 5108 5063
q2 242 318 223 223
q3 2134 2652 2274 2274
q4 1384 1782 1349 1349
q5 4570 4447 4406 4406
q6 219 169 128 128
q7 2038 1923 1736 1736
q8 2560 2493 2471 2471
q9 7101 7061 7108 7061
q10 2975 3166 2743 2743
q11 588 503 486 486
q12 702 768 618 618
q13 3490 3934 3283 3283
q14 293 291 268 268
q15 503 476 471 471
q16 429 493 425 425
q17 1206 1641 1370 1370
q18 7724 7544 7336 7336
q19 793 792 825 792
q20 2034 2015 1917 1917
q21 4732 4316 4317 4316
q22 1067 1014 966 966
Total cold run time: 51951 ms
Total hot run time: 49702 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2917227631
<details>
<summary>ClickBench: <b>Total hot run time: 28.97 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1cd18b711587bd2f89a2d33af830143cf3959740, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.11 0.11
query3 0.25 0.19 0.19
query4 1.59 0.19 0.19
query5 0.47 0.43 0.43
query6 1.17 0.66 0.65
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.59 0.52 0.53
query10 0.56 0.57 0.57
query11 0.15 0.11 0.11
query12 0.15 0.11 0.12
query13 0.62 0.59 0.60
query14 0.80 0.80 0.82
query15 0.88 0.85 0.88
query16 0.39 0.39 0.38
query17 1.04 1.06 1.05
query18 0.23 0.22 0.21
query19 1.97 1.86 1.83
query20 0.02 0.01 0.01
query21 15.40 0.89 0.54
query22 0.74 1.20 0.66
query23 14.92 1.40 0.62
query24 7.04 1.76 0.72
query25 0.47 0.25 0.08
query26 0.61 0.17 0.15
query27 0.04 0.05 0.06
query28 9.88 0.91 0.45
query29 12.57 4.03 3.32
query30 0.25 0.09 0.06
query31 2.83 0.61 0.38
query32 3.22 0.55 0.47
query33 3.05 3.06 3.07
query34 15.73 5.10 4.46
query35 4.47 4.46 4.54
query36 0.65 0.49 0.48
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.17 0.14 0.13
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.46 s
Total hot run time: 28.97 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918011106
<details>
<summary>TPC-DS: <b>Total hot run time: 191652 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86163cd5082d6124d7bcb919a7024c918fad4574, data reload: false
query1 1405 1094 1061 1061
query2 6341 1801 1839 1801
query3 11049 4532 4529 4529
query4 53345 25748 22906 22906
query5 5192 518 450 450
query6 348 188 190 188
query7 4876 516 291 291
query8 272 228 215 215
query9 5483 2604 2606 2604
query10 458 320 282 282
query11 15019 15340 14717 14717
query12 165 110 109 109
query13 1042 530 391 391
query14 10101 6394 6558 6394
query15 215 198 190 190
query16 7068 664 505 505
query17 1119 790 598 598
query18 1607 419 313 313
query19 206 199 183 183
query20 131 128 116 116
query21 211 127 111 111
query22 4469 4402 4346 4346
query23 34304 33347 33626 33347
query24 6713 2381 2437 2381
query25 481 480 411 411
query26 715 272 153 153
query27 2325 515 338 338
query28 3050 2156 2149 2149
query29 576 584 453 453
query30 276 222 191 191
query31 833 887 767 767
query32 70 60 64 60
query33 453 363 324 324
query34 764 904 557 557
query35 783 824 742 742
query36 919 1007 882 882
query37 110 102 80 80
query38 4243 4228 4279 4228
query39 1530 1470 1448 1448
query40 213 116 111 111
query41 66 60 58 58
query42 130 114 107 107
query43 494 525 498 498
query44 1358 877 846 846
query45 182 174 164 164
query46 852 1011 632 632
query47 1883 1888 1799 1799
query48 398 436 342 342
query49 638 516 413 413
query50 687 713 403 403
query51 4201 4293 4210 4210
query52 107 105 106 105
query53 230 257 193 193
query54 591 571 521 521
query55 87 92 84 84
query56 316 299 277 277
query57 1166 1221 1138 1138
query58 275 313 259 259
query59 2756 2896 2715 2715
query60 325 322 319 319
query61 129 128 157 128
query62 717 708 660 660
query63 230 180 184 180
query64 1750 1022 678 678
query65 4283 4236 4187 4187
query66 720 414 300 300
query67 16104 15709 15463 15463
query68 7524 879 526 526
query69 533 350 262 262
query70 1211 1075 1087 1075
query71 502 328 293 293
query72 5566 4823 4904 4823
query73 1469 637 361 361
query74 9199 9230 8635 8635
query75 3848 3225 2678 2678
query76 4273 1193 753 753
query77 615 360 298 298
query78 9919 10217 9314 9314
query79 2181 779 584 584
query80 680 512 434 434
query81 476 266 220 220
query82 406 122 99 99
query83 368 255 229 229
query84 290 110 92 92
query85 797 367 315 315
query86 344 288 254 254
query87 4432 4474 4302 4302
query88 2905 2274 2244 2244
query89 417 324 287 287
query90 1959 206 203 203
query91 141 138 110 110
query92 76 59 53 53
query93 1159 931 585 585
query94 699 421 303 303
query95 376 292 277 277
query96 486 579 281 281
query97 2712 2722 2689 2689
query98 237 209 195 195
query99 1412 1387 1277 1277
Total cold run time: 296367 ms
Total hot run time: 191652 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918196071
# BE Regression && UT Coverage Report
Increment line coverage `56.65% (179/316)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/51343_86163cd5082d6124d7bcb919a7024c918fad4574_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/51343_86163cd5082d6124d7bcb919a7024c918fad4574_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.45% (20871/26271) |
| Line Coverage | 72.63% (215479/296694) |
| Region Coverage | 70.87% (126708/178797) |
| Branch Coverage | 64.58% (65656/101672) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918468241
<details>
<summary>TPC-DS: <b>Total hot run time: 185796 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6deab91aa93935e57747c73d630d74751de7e2a7, data reload: false
query1 1024 493 526 493
query2 6554 1878 1863 1863
query3 6763 226 215 215
query4 26232 24171 23343 23343
query5 4839 626 468 468
query6 317 213 197 197
query7 4634 499 296 296
query8 279 227 218 218
query9 8633 2637 2662 2637
query10 498 338 285 285
query11 15691 14994 14790 14790
query12 155 115 109 109
query13 1657 544 410 410
query14 9146 6189 6256 6189
query15 200 189 172 172
query16 7242 621 432 432
query17 1173 706 573 573
query18 1975 397 294 294
query19 193 178 159 159
query20 121 114 122 114
query21 220 130 107 107
query22 4109 4212 3975 3975
query23 33986 32861 32948 32861
query24 8398 2419 2396 2396
query25 528 454 391 391
query26 1228 274 156 156
query27 2740 511 344 344
query28 4288 2157 2136 2136
query29 779 538 433 433
query30 289 213 188 188
query31 922 835 743 743
query32 72 67 65 65
query33 559 365 305 305
query34 793 864 526 526
query35 773 819 716 716
query36 965 977 869 869
query37 112 101 79 79
query38 4235 4234 4053 4053
query39 1486 1421 1435 1421
query40 209 121 106 106
query41 63 60 64 60
query42 127 107 107 107
query43 483 500 490 490
query44 1312 863 832 832
query45 174 181 168 168
query46 840 1026 620 620
query47 1763 1769 1752 1752
query48 377 430 304 304
query49 746 511 393 393
query50 648 663 394 394
query51 4117 4141 4180 4141
query52 111 110 97 97
query53 226 252 189 189
query54 569 579 516 516
query55 91 79 82 79
query56 310 312 298 298
query57 1138 1158 1063 1063
query58 267 262 249 249
query59 2727 2687 2699 2687
query60 333 328 307 307
query61 131 126 129 126
query62 811 719 648 648
query63 222 190 186 186
query64 4361 1008 783 783
query65 4218 4106 4148 4106
query66 1151 420 369 369
query67 15842 15755 15452 15452
query68 7958 923 529 529
query69 464 313 268 268
query70 1180 1086 1085 1085
query71 471 324 306 306
query72 5561 4777 4729 4729
query73 662 607 354 354
query74 9168 9033 8786 8786
query75 3849 3196 2666 2666
query76 3737 1181 790 790
query77 802 386 288 288
query78 10096 10236 9271 9271
query79 2613 820 584 584
query80 680 530 445 445
query81 483 257 223 223
query82 455 132 96 96
query83 255 251 237 237
query84 256 112 96 96
query85 774 360 321 321
query86 390 294 254 254
query87 4431 4456 4326 4326
query88 3837 2316 2295 2295
query89 392 320 291 291
query90 1868 219 214 214
query91 143 152 113 113
query92 73 106 57 57
query93 2005 986 588 588
query94 660 414 292 292
query95 373 300 292 292
query96 502 571 287 287
query97 2712 2773 2699 2699
query98 249 204 199 199
query99 1705 1424 1272 1272
Total cold run time: 275979 ms
Total hot run time: 185796 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918021026
<details>
<summary>ClickBench: <b>Total hot run time: 29.58 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86163cd5082d6124d7bcb919a7024c918fad4574, data reload: false
query1 0.04 0.05 0.03
query2 0.12 0.11 0.11
query3 0.25 0.19 0.19
query4 1.59 0.19 0.18
query5 0.45 0.46 0.43
query6 1.46 0.66 0.66
query7 0.03 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.52 0.50
query10 0.59 0.58 0.56
query11 0.16 0.11 0.11
query12 0.14 0.11 0.12
query13 0.62 0.60 0.59
query14 0.80 0.82 0.81
query15 0.87 0.85 0.88
query16 0.37 0.38 0.38
query17 0.99 1.06 1.04
query18 0.23 0.20 0.20
query19 1.87 1.84 1.79
query20 0.02 0.01 0.01
query21 15.40 0.92 0.55
query22 0.76 1.29 1.16
query23 14.68 1.36 0.61
query24 7.26 1.16 0.96
query25 0.48 0.11 0.16
query26 0.61 0.16 0.12
query27 0.06 0.05 0.04
query28 9.64 0.88 0.46
query29 12.54 4.04 3.31
query30 0.27 0.09 0.07
query31 2.82 0.60 0.39
query32 3.23 0.55 0.47
query33 3.09 3.04 3.05
query34 15.62 5.08 4.43
query35 4.53 4.55 4.49
query36 0.65 0.49 0.48
query37 0.09 0.06 0.07
query38 0.05 0.04 0.03
query39 0.04 0.02 0.03
query40 0.17 0.14 0.12
query41 0.08 0.02 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 103.37 s
Total hot run time: 29.58 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2917948237
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918044083
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](agg_state) Add new version of function map_agg [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51343:
URL: https://github.com/apache/doris/pull/51343#issuecomment-2918112484
# BE UT Coverage Report
Increment line coverage `1.90% (6/316)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/86163cd5082d6124d7bcb919a7024c918fad4574_86163cd5082d6124d7bcb919a7024c918fad4574/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/86163cd5082d6124d7bcb919a7024c918fad4574_86163cd5082d6124d7bcb919a7024c918fad4574/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.01% (14947/26688) |
| Line Coverage | 44.81% (132953/296707) |
| Region Coverage | 43.87% (66807/152287) |
| Branch Coverage | 38.51% (34288/89040) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org