You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 19:26:35 UTC

[GitHub] [beam] kennknowles opened a new issue, #18593: Stop depending on Test JARs

kennknowles opened a new issue, #18593:
URL: https://github.com/apache/beam/issues/18593

   Testing components can be in a testing or otherwise signaled package, but shouldn't really be depended on by depending on a test jar in the test scope.
   
   Imported from Jira [BEAM-3138](https://issues.apache.org/jira/browse/BEAM-3138). Original Jira may contain additional context.
   Reported by: tgroh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #18593: Stop depending on Test JARs

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #18593:
URL: https://github.com/apache/beam/issues/18593#issuecomment-1157938465

   oh interesting, thanks for the pointer!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on issue #18593: Stop depending on Test JARs

Posted by GitBox <gi...@apache.org>.
Abacn commented on issue #18593:
URL: https://github.com/apache/beam/issues/18593#issuecomment-1157890839

   Starting from gradle 5.7 testfixtures plugin is officially added. Should be able to use this instead of the usage of classes property `project(...).sourceSets.test.output`  which is deprecated.
   (documentation: https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures; example: https://stackoverflow.com/questions/5644011/multi-project-test-dependencies-with-gradle)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #18593: Stop depending on Test JARs

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #18593:
URL: https://github.com/apache/beam/issues/18593#issuecomment-1157941283

   We could use that for ValidatesRunner
   
   Separately, we have some uses of `test` scoped jars as utility libraries, which is simply incorrect usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Stop depending on Test JARs [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #18593:
URL: https://github.com/apache/beam/issues/18593#issuecomment-3175418954

   By taking apache/beam-starter-java and switching runner to Dataflow I immediately got this, which seems likely related to the improper use of `test` scope dependencies:
   
   ```
   Caused by: java.lang.ClassNotFoundException: org.apache.beam.sdk.testing.SerializableMatcher
      ...
       at org.apache.beam.sdk.options.PipelineOptionsFactory$Cache.validateWellFormed (PipelineOptionsFactory.java:2161)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org