[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4092: HIVE-27116: HS2 need to send owner info for UDFs in the HivePrivilege…

["dengzhhu653 (via GitHub)" <gi...@apache.org>]

dengzhhu653 commented on code in PR #4092:
URL: https://github.com/apache/hive/pull/4092#discussion_r1125882214


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/AbstractFunctionAnalyzer.java:
##########
@@ -66,11 +70,24 @@ protected void addEntities(String functionName, String className, boolean isTemp
     }
     if (database != null) {
       outputs.add(new WriteEntity(database, WriteEntity.WriteType.DDL_NO_LOCK));
+      // Add the permanent function as a WriteEntity
+      Function function;
+      if (isCreate) {

Review Comment:
   Can we use `queryState.getHiveOperation() == HiveOperation.CREATEFUNCTION` instead of passing an argument `isCreate`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org