You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pateash (via GitHub)" <gi...@apache.org> on 2023/12/11 09:06:32 UTC
[PR] 34838 adding propertyfiles option [airflow]
pateash opened a new pull request, #36164:
URL: https://github.com/apache/airflow/pull/36164
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #34838
## Description
There is an option to override the default conf/spark-defaults.conf properties in Spark-submit
We want to have that option in SparkSubmitOperator and Hook as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "pateash (via GitHub)" <gi...@apache.org>.
pateash commented on PR #36164:
URL: https://github.com/apache/airflow/pull/36164#issuecomment-1849660732
cc. @ghostp13409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36164:
URL: https://github.com/apache/airflow/pull/36164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #36164:
URL: https://github.com/apache/airflow/pull/36164#discussion_r1422337135
##########
tests/system/providers/apache/hive/example_twitter_README.md:
##########
@@ -33,7 +33,7 @@
1. Save Summary to MySQL
***Screenshot:***
-<img src="http://i.imgur.com/rRpSO12.png" width="99%"/>
+<img src="http://i.imgur.com/rRpSO12.png" width="99%" alt="Dag for Collecting tweets for four users account"/>
Review Comment:
Is this change related to the main goal of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #36164:
URL: https://github.com/apache/airflow/pull/36164#discussion_r1422658466
##########
tests/system/providers/apache/hive/example_twitter_README.md:
##########
@@ -33,7 +33,7 @@
1. Save Summary to MySQL
***Screenshot:***
-<img src="http://i.imgur.com/rRpSO12.png" width="99%"/>
+<img src="http://i.imgur.com/rRpSO12.png" width="99%" alt="Dag for Collecting tweets for four users account"/>
Review Comment:
Fixed in https://github.com/apache/airflow/pull/36169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "pateash (via GitHub)" <gi...@apache.org>.
pateash commented on code in PR #36164:
URL: https://github.com/apache/airflow/pull/36164#discussion_r1422344802
##########
tests/system/providers/apache/hive/example_twitter_README.md:
##########
@@ -33,7 +33,7 @@
1. Save Summary to MySQL
***Screenshot:***
-<img src="http://i.imgur.com/rRpSO12.png" width="99%"/>
+<img src="http://i.imgur.com/rRpSO12.png" width="99%" alt="Dag for Collecting tweets for four users account"/>
Review Comment:
No, this was a pre-commit failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "bolkedebruin (via GitHub)" <gi...@apache.org>.
bolkedebruin commented on PR #36164:
URL: https://github.com/apache/airflow/pull/36164#issuecomment-1849903736
Can you add tests please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SparkSubmit: Adding propertyfiles option [airflow]
Posted by "pateash (via GitHub)" <gi...@apache.org>.
pateash commented on code in PR #36164:
URL: https://github.com/apache/airflow/pull/36164#discussion_r1422344802
##########
tests/system/providers/apache/hive/example_twitter_README.md:
##########
@@ -33,7 +33,7 @@
1. Save Summary to MySQL
***Screenshot:***
-<img src="http://i.imgur.com/rRpSO12.png" width="99%"/>
+<img src="http://i.imgur.com/rRpSO12.png" width="99%" alt="Dag for Collecting tweets for four users account"/>
Review Comment:
No, this was a pre-commit failure.
as all the images need an alt-text, may be due to addition of this new rule
https://github.com/DavidAnson/markdownlint/blob/main/doc/md045.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org