You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by ab...@apache.org on 2018/03/21 08:30:50 UTC
[32/50] incubator-gobblin git commit: [GOBBLIN-411] Fix bug in FIFO
based pull file loader
[GOBBLIN-411] Fix bug in FIFO based pull file loader
Closes #2288 from arjun4084346/sortFix
Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/4f522302
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/4f522302
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/4f522302
Branch: refs/heads/0.12.0
Commit: 4f5223028ebf3f79349720cca2f80f9dabf8f604
Parents: 4997fa9
Author: Arjun <ab...@linkedin.com>
Authored: Thu Feb 15 20:52:17 2018 -0800
Committer: Hung Tran <hu...@linkedin.com>
Committed: Thu Feb 15 20:52:17 2018 -0800
----------------------------------------------------------------------
.../src/main/java/org/apache/gobblin/util/PullFileLoader.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/4f522302/gobblin-utility/src/main/java/org/apache/gobblin/util/PullFileLoader.java
----------------------------------------------------------------------
diff --git a/gobblin-utility/src/main/java/org/apache/gobblin/util/PullFileLoader.java b/gobblin-utility/src/main/java/org/apache/gobblin/util/PullFileLoader.java
index 210615c..9270491 100644
--- a/gobblin-utility/src/main/java/org/apache/gobblin/util/PullFileLoader.java
+++ b/gobblin-utility/src/main/java/org/apache/gobblin/util/PullFileLoader.java
@@ -168,7 +168,7 @@ public class PullFileLoader {
private List<Config> getSortedConfigs(List<ConfigWithTimeStamp> configsWithTimeStamps) {
List<Config> sortedConfigs = Lists.newArrayList();
- Collections.sort(configsWithTimeStamps, (config1, config2) -> (config1.timeStamp > config2.timeStamp) ? 1 : -1);
+ Collections.sort(configsWithTimeStamps, Comparator.comparingLong(o -> o.timeStamp));
for (ConfigWithTimeStamp configWithTimeStamp : configsWithTimeStamps) {
sortedConfigs.add(configWithTimeStamp.config);
}