You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by ch...@apache.org on 2026/03/31 11:21:16 UTC

(gluten) branch main updated: [VL] Clean up GPU code: remove dead/redundant code (#11824)

This is an automated email from the ASF dual-hosted git repository.

chengchengjin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new 999ba5fe1e [VL] Clean up GPU code: remove dead/redundant code (#11824)
999ba5fe1e is described below

commit 999ba5fe1ee623106e8cafee399c7867a6f889c8
Author: Ankita Victor <an...@microsoft.com>
AuthorDate: Tue Mar 31 16:51:08 2026 +0530

    [VL] Clean up GPU code: remove dead/redundant code (#11824)
---
 cpp/velox/cudf/GpuLock.cc                  | 8 +++-----
 cpp/velox/shuffle/VeloxGpuShuffleReader.cc | 1 -
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/cpp/velox/cudf/GpuLock.cc b/cpp/velox/cudf/GpuLock.cc
index 85ddbcd578..1865fec2b6 100644
--- a/cpp/velox/cudf/GpuLock.cc
+++ b/cpp/velox/cudf/GpuLock.cc
@@ -45,7 +45,6 @@ void lockGpu() {
         return;
     }
 
-
     // Wait until the GPU lock becomes available
     getGpuLockState().gGpuCv.wait(lock, [] {
         return !getGpuLockState().gGpuOwner.has_value();
@@ -72,12 +71,12 @@ void unlockGpu() {
     std::thread::id tid = std::this_thread::get_id();
     std::unique_lock<std::mutex> lock(getGpuLockState().gGpuMutex);
     if (!getGpuLockState().gGpuOwner.has_value()) {
-        LOG(INFO) <<"unlockGpu() called by non-owner thread!"<< std::endl;
+        LOG(INFO) << "unlockGpu() called when no thread holds the lock!";
         return;
     }
 
-    if (!getGpuLockState().gGpuOwner.has_value() || getGpuLockState().gGpuOwner != tid) {
-        throw std::runtime_error("unlockGpu() called by other-owner thread!");
+    if (getGpuLockState().gGpuOwner != tid) {
+        throw std::runtime_error("unlockGpu() called by other thread!");
     }
 
     // Release ownership
@@ -88,5 +87,4 @@ void unlockGpu() {
     getGpuLockState().gGpuCv.notify_one();
 }
 
-
 } // namespace gluten
diff --git a/cpp/velox/shuffle/VeloxGpuShuffleReader.cc b/cpp/velox/shuffle/VeloxGpuShuffleReader.cc
index 441cb0d066..2c95fa2594 100644
--- a/cpp/velox/shuffle/VeloxGpuShuffleReader.cc
+++ b/cpp/velox/shuffle/VeloxGpuShuffleReader.cc
@@ -75,7 +75,6 @@ bool VeloxGpuHashShuffleReaderDeserializer::resolveNextBlockType() {
     default:
       throw GlutenException(fmt::format("Unsupported block type: {}", static_cast<int32_t>(blockType)));
   }
-  return true;
 }
 
 void VeloxGpuHashShuffleReaderDeserializer::loadNextStream() {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org