You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jira-importer (via GitHub)" <gi...@apache.org> on 2025/04/02 08:49:12 UTC
[I] [MINSTALL-115] Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms [maven-install-plugin]
jira-importer opened a new issue, #276:
URL: https://github.com/apache/maven-install-plugin/issues/276
**[Philip Pearson](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=prgp)** opened **[MINSTALL-115](https://issues.apache.org/jira/browse/MINSTALL-115?redirect=false)** and commented
When the `installAtEnd` configuration parameter is set to `true` on a multimodule project with multiple class realms then because a different class loaders creates instances of the `InstallMojo` class there will be muliple instances of `readyProjectsCounter` and `installRequests`.
However, because the end is determined by `projectsReady = readyProjectsCounter.incrementAndGet() == reactorProjects.size()` it will never complete as `readyProjectsCounter` will never equal the size `reactorProjects` if even one project is executed in another class realm.
`maven-deploy-plugin` partially solved this in MDEPLOY-193 by using `project.equals(reactorProjects.get(reactorProjects.size() - 1))` instead. However, the installation is a little more complex than the deploy as we need to read the used the `createChecksum` and `updateReleaseInfo` configuration parameters from each installed project - we can't store them ahead of time because of the issue with the class realms, so we need to read the plugin configurations before we can call `installProject(instalRequest)`.
---
**Affects:** 2.5.2
**Attachments:**
- [InstallConfiguration.java](https://issues.apache.org/jira/secure/attachment/12749654/InstallConfiguration.java) (_3.14 kB_)
- [mojo.patch](https://issues.apache.org/jira/secure/attachment/12749653/mojo.patch) (_2.75 kB_)
- [oginsta-10-14-0.apk](https://issues.apache.org/jira/secure/attachment/12951363/oginsta-10-14-0.apk) (_25.38 MB_)
**Issue Links:**
- [MINSTALL-102](https://issues.apache.org/jira/browse/MINSTALL-102) installAtEnd does not install artifacts for multi-module with packaging maven-archetype
- [KYLIN-3644](https://issues.apache.org/jira/browse/KYLIN-3644) NumberFormatExcetion on null values when building cube with Spark
(_**"is required by"**_)
**Remote Links:**
- [GitHub Pull Request #1
](https://github.com/apache/maven-install-plugin/pull/1)
- [GitHub Pull Request #15
](https://github.com/apache/maven-install-plugin/pull/15)
1 votes, 6 watchers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [MINSTALL-115] Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms [maven-install-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #276:
URL: https://github.com/apache/maven-install-plugin/issues/276#issuecomment-2771863459
**[Leonard Brünings](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=leonard84)** commented
This also happens if different versions of the install/deploy plugins are used in the multimodule build. I hope this gets fixed soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [MINSTALL-115] Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms [maven-install-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #276:
URL: https://github.com/apache/maven-install-plugin/issues/276#issuecomment-2771863448
**[Philip Pearson](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=prgp)** commented
There is a similar change required in `maven-deploy-plugin` - I have created a fork which includes both sets as changes (as separate commits) - https://github.com/prgp/maven-plugins/tree/prgp-MINSTALL-115
\\
\\
* `maven-install-plugin` changes are in [commit 3574e045a2af1146a98ed51af119a2a045204519](https://github.com/prgp/maven-plugins/commit/3574e045a2af1146a98ed51af119a2a045204519)
* `maven-deploy-plugin` changes are in [commit e5b4c279de2e8e0de0dd7638144f4f93cfcac66e](https://github.com/prgp/maven-plugins/commit/e5b4c279de2e8e0de0dd7638144f4f93cfcac66e)
These commits should cope with the edge care where any of the modules (except the last) are not using `installAtEnd` (/`deployAtEnd`) set to true or older versions. However, it currently does not handle last modules that are using an older `maven-install-plugin` (/`maven-deploy-plugin`) versions - I suppose the `isLastProject()` method could be altered so that it scans backwards through the reactor projects to find the first version that can support `installAtEnd` (/`deployAtEnd`) correctly and use that as the 'last' project ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [MINSTALL-115] Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms [maven-install-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #276:
URL: https://github.com/apache/maven-install-plugin/issues/276#issuecomment-2771863453
**[Charles Honton](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=charles_honton@intuit.com)** commented
I suspect installAtEnd has same problems as deployAtEnd. see MDEPLOY-200, MDEPLOY-224, MDEPLOY-225, and MDEPLOY-226 for a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [MINSTALL-115] Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms [maven-install-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #276:
URL: https://github.com/apache/maven-install-plugin/issues/276#issuecomment-2771863443
**[Philip Pearson](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=prgp)** commented
The attached files are sufficient to fixed the issue for me, but the `InstallConfiguration` class makes certain assumptions about the configuration object which probably could be improved upon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org