You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/06/15 06:57:00 UTC

[GitHub] flink pull request #4129: [FLINK-6918] [tests] Harden AbstractOperatorRestor...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4129

    [FLINK-6918] [tests] Harden AbstractOperatorRestoreTestBase by retrying CancelWithSavepoint messages

    The problem is that a StreamTask can be in state RUNNING without internally being running.
    As a consequence checkpoint message will be discarded. This problem will be solved once
    FLINK-4714 has been addressed. Until then, we harden the test case by retrying the
    CancelWithSavepoint message.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink hardenAbstractOperatorRestoreTestBase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4129
    
----
commit 7587fa23b3fb0f3ef8d799625ea78bf58046128f
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-06-15T06:54:42Z

    [FLINK-6918] [tests] Harden AbstractOperatorRestoreTestBase by retrying CancelWithSavepoint messages
    
    The problem is that a StreamTask can be in state RUNNING without internally being running.
    As a consequence checkpoint message will be discarded. This problem will be solved once
    FLINK-4714 has been addressed. Until then, we harden the test case by retrying the
    CancelWithSavepoint message.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4129: [FLINK-6918] [tests] Harden AbstractOperatorRestoreTestBa...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4129
  
    Thanks for reviewing @zentol. Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4129: [FLINK-6918] [tests] Harden AbstractOperatorRestoreTestBa...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4129
  
    +1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4129: [FLINK-6918] [tests] Harden AbstractOperatorRestor...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---