You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/25 08:30:33 UTC
[GitHub] [echarts] jiawulin001 opened a new pull request, #16941: fix: Enable 'nameTextStyle.width' to take effect
jiawulin001 opened a new pull request, #16941:
URL: https://github.com/apache/echarts/pull/16941
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Enable user to use `nameTextStyle.width` to adjust the maximum width of axis name text rect.
### Fixed issues
- fix #16940
## Details
### Before: What was the problem?
User cannot change the width of axis name text rect with attribute `nameTextStyle.width`. The reason for this can be referred to at https://github.com/apache/echarts/issues/16940#issuecomment-1108227649
<img width="942" alt="before #16940" src="https://user-images.githubusercontent.com/14244944/165050791-ddf3d277-fb89-4c56-b339-41e538db3be4.png">
### After: How is it fixed in this PR?
Now by specifying `nameTextStyle.width`, user can limit the maximum width of the text rect.
<img width="946" alt="after #16940" src="https://user-images.githubusercontent.com/14244944/165051004-6866602e-6f21-4de7-8497-7e9fc06bd7c5.png">
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16941: fix: Enable 'nameTextStyle.width' to take effect
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #16941:
URL: https://github.com/apache/echarts/pull/16941#issuecomment-1108267399
Seems already exists an PR https://github.com/apache/echarts/pull/16206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #16941: fix: Enable 'nameTextStyle.width' to take effect
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #16941:
URL: https://github.com/apache/echarts/pull/16941#issuecomment-1108273461
Oh, sorry didn't know that. Will close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16941: fix: Enable 'nameTextStyle.width' to take effect
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16941:
URL: https://github.com/apache/echarts/pull/16941#issuecomment-1108248263
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 closed pull request #16941: fix: Enable 'nameTextStyle.width' to take effect
Posted by GitBox <gi...@apache.org>.
jiawulin001 closed pull request #16941: fix: Enable 'nameTextStyle.width' to take effect
URL: https://github.com/apache/echarts/pull/16941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org