You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/07/25 15:55:37 UTC
[GitHub] storm pull request #2242: [STORM-1347] display topology version on UI
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2242
[STORM-1347] display topology version on UI
Display topology version on UI.
see: https://issues.apache.org/jira/browse/STORM-1347
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm STORM-1347
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2242
----
commit 3e24d0398d35a628df4dbe5a432ec979e329bde8
Author: Ethan Li <et...@gmail.com>
Date: 2017-07-25T15:21:15Z
[STORM-1347] display the topology version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2242
Thanks for review @HeartSaVioR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2242: [STORM-1347] display topology version on UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2242
Actually this issue is the subtask of topology online update, and topology version is expected to be set automatically to the increasing number.
But I also think this patch doesn't hurt in any way. When we support online update and have version, we can just overwrite `topology.version` only if user doesn't set custom version string.
Moreover, supporting version as label looks like good idea indeed.
+1 on this. Thanks @Ethanlm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2242
Thanks @HeartSaVioR Regenerated them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2242
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2242
@Ethanlm
Sorry there's merge conflict now. Could you resolve this?
You may want to just regenerate classes from thrift since the conflict occurs from generated files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2242: [STORM-1347] display topology version on UI
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2242
storm-cassandra failed. Should be not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---