You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Petrov (Jira)" <ji...@apache.org> on 2020/04/03 16:12:00 UTC
[jira] [Comment Edited] (CASSANDRA-15684) CASSANDRA-15650 was
merged after dtest refactor and modified classes no longer in the project
[ https://issues.apache.org/jira/browse/CASSANDRA-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074695#comment-17074695 ]
Alex Petrov edited comment on CASSANDRA-15684 at 4/3/20, 4:11 PM:
------------------------------------------------------------------
+1 for a Cassandra change.
[~mck] if I understand the nature of the failure correctly, the main problem was merge. It was unintentional, and the patch itself was good, just based off earlier commit.
I'll have to take a closer look at the dtest patch on Monday.
was (Author: ifesdjeen):
+1 for a Cassandra change.
I'll have to take a closer look at the dtest patch on Monday.
> CASSANDRA-15650 was merged after dtest refactor and modified classes no longer in the project
> ---------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CASSANDRA-15650 was based off commits before CASSANDRA-15539 which removed some of the files modified in CASSANDRA-15650. The tests were passing pre-merge but off earlier commits. On commit they started failing since the dtest API no longer match so produces the following exception
> {code}
> [junit-timeout] org.apache.cassandra.distributed.api.NodeToolResult$Asserts.errorContains([Ljava/lang/String;)Lorg/apache/cassandra/distributed/api/NodeToolResult$Asserts;
> [junit-timeout] java.lang.NoSuchMethodError: org.apache.cassandra.distributed.api.NodeToolResult$Asserts.errorContains([Ljava/lang/String;)Lorg/apache/cassandra/distributed/api/NodeToolResult$Asserts;
> [junit-timeout] at org.apache.cassandra.distributed.test.RepairCoordinatorFast.lambda$unknownHost$5(RepairCoordinatorFast.java:216)
> [junit-timeout] at org.apache.cassandra.utils.AssertUtil.lambda$assertTimeoutPreemptively$0(AssertUtil.java:39)
> [junit-timeout] at org.apache.cassandra.utils.AssertUtil.lambda$assertTimeoutPreemptively$1(AssertUtil.java:67)
> [junit-timeout] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [junit-timeout] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [junit-timeout] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [junit-timeout] at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> [junit-timeout] at java.lang.Thread.run(Thread.java:748)
> {code}
> Root cause was 4 files exited which should have been deleted in CASSANDRA-15539. Since they were not when CASSANDRA-15650 modified one it didn't cause a merge conflict, but when the test runs it conflicts and fails.
> [Circle CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15684]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org