You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/26 15:48:17 UTC
[GitHub] [tvm] hope51607 opened a new pull request #9374: [BugFix][Opencl] Explicitly cast min/max operands
hope51607 opened a new pull request #9374:
URL: https://github.com/apache/tvm/pull/9374
I encountered the same max / min ambiguous issue caused by the ternary operator as #2821 and #5090.
The reason is that the type of the ternary operator is not unchar.
The patch that fixes this problem seems to be missing in #5107 .
This pr simply adds them back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hope51607 commented on pull request #9374: [BugFix][Opencl] Explicitly cast min/max operands
Posted by GitBox <gi...@apache.org>.
hope51607 commented on pull request #9374:
URL: https://github.com/apache/tvm/pull/9374#issuecomment-952475916
@shingjan I have enabled these tests and confirmed that they passed.
@masahi I tried to add fp16 test, but in my environment it does not seem to support half-precision floating point.
I am confused whether to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #9374: [BugFix][Opencl] Explicitly cast min/max operands
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9374:
URL: https://github.com/apache/tvm/pull/9374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #9374: [BugFix][Opencl] Explicitly cast min/max operands
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9374:
URL: https://github.com/apache/tvm/pull/9374#issuecomment-952329871
@hope51607 Can you also add fp16 tests? I've met the "type ambiguity" error when trying to compile fp16 models for opencl before. I assume this patch fixes such issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org