[GitHub] stevedlawrence commented on issue #29: Fixed bug in calculating bit length for delimited unparsing

[GitBox <gi...@apache.org>]

stevedlawrence commented on issue #29: Fixed bug in calculating bit length for delimited unparsing
URL: https://github.com/apache/incubator-daffodil/pull/29#issuecomment-360635089
 
 
   If I understand BCD correctly, 3<sub>10</sub> = 0x3C<sub>BCD</sub>. Since minLength defaults to zero if not supplied, if will unparse to the minimum number of bytes needed, which is just 0x3C. If you had minLength="2" on the other hand, then it should pad 0x3C to 2 bytes, in which case I would expect 0x003C.
   
   So I think the test just needs to be updated to either specify minLength or to not expect the zeros (or maybe add some extra tests so both cases are covered). Same thing applies for the DelimitedPackedDecSeq test which uparses 0.03.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services