You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by an...@apache.org on 2010/01/26 18:41:28 UTC

svn commit: r903337 - in /ant/core/trunk: WHATSNEW src/script/ant.bat

Author: antoine
Date: Tue Jan 26 17:41:27 2010
New Revision: 903337

URL: http://svn.apache.org/viewvc?rev=903337&view=rev
Log:
fix for bug 48186 ant.bat file ignores -noclasspath if it is the first parameter supplied by Ken Southerland.

Modified:
    ant/core/trunk/WHATSNEW
    ant/core/trunk/src/script/ant.bat

Modified: ant/core/trunk/WHATSNEW
URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=903337&r1=903336&r2=903337&view=diff
==============================================================================
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Tue Jan 26 17:41:27 2010
@@ -9,6 +9,10 @@
 Fixed bugs:
 -----------
 
+ * ant.bat can now also process the -noclasspath switch when it is 
+   the first switch on a command line.
+   Bugzilla Report 48186.
+
  * <fixcrlf> now tries to delete the created temporary files earlier.
    Bugzilla Report 48506.
 

Modified: ant/core/trunk/src/script/ant.bat
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/script/ant.bat?rev=903337&r1=903336&r2=903337&view=diff
==============================================================================
--- ant/core/trunk/src/script/ant.bat (original)
+++ ant/core/trunk/src/script/ant.bat Tue Jan 26 17:41:27 2010
@@ -59,9 +59,6 @@
 
 rem Slurp the command line arguments. This loop allows for an unlimited number
 rem of arguments (up to the command line limit, anyway).
-set ANT_CMD_LINE_ARGS=%1
-if ""%1""=="""" goto doneStart
-shift
 :setupArgs
 if ""%1""=="""" goto doneStart
 if ""%1""==""-noclasspath"" goto clearclasspath



Re: svn commit: r903337 - in /ant/core/trunk: WHATSNEW src/script/ant.bat

Posted by Antoine Levy Lambert <an...@gmx.de>.
Stefan Bodewig wrote:
> On 2010-01-26, <an...@apache.org> wrote:
>
>   
>> -set ANT_CMD_LINE_ARGS=%1
>> -if ""%1""=="""" goto doneStart
>> -shift
>>     
>
> The code was there to ensure ANT_CMD_LINE_ARGS was not empty before
> running
>
> set ANT_CMD_LINE_ARGS=%ANT_CMD_LINE_ARGS% %1
>
> (at least that's my interpretation).  Given that it works for you
> without the removed code, could this be something that was introduced
> for Win9x and is no longer required on later versions?
>   
I did not take the time to read the history of ant.bat to figure out the 
genesis of what we currently have. Maybe these lines were required for 
Win9x. On current Windows versions, evaluating %VARIABLE% when VARIABLE 
is not set does not create an error as far as I know. Maybe these lines 
were just cruft in any case.
> Do we still support Win9x officially?  [I don't think we ought to.]
>   
We do not support Win9x. [1]
> Stefan
>
>   
Antoine
[1] http://ant.apache.org/manual/platform.html


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: svn commit: r903337 - in /ant/core/trunk: WHATSNEW src/script/ant.bat

Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-01-26, <an...@apache.org> wrote:

> -set ANT_CMD_LINE_ARGS=%1
> -if ""%1""=="""" goto doneStart
> -shift

The code was there to ensure ANT_CMD_LINE_ARGS was not empty before
running

set ANT_CMD_LINE_ARGS=%ANT_CMD_LINE_ARGS% %1

(at least that's my interpretation).  Given that it works for you
without the removed code, could this be something that was introduced
for Win9x and is no longer required on later versions?

Do we still support Win9x officially?  [I don't think we ought to.]

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org