You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "NickLarsenNZ (via GitHub)" <gi...@apache.org> on 2023/05/25 22:36:12 UTC
[GitHub] [superset] NickLarsenNZ opened a new pull request, #24222: fix(helm): Use correct default hostname for postgres
NickLarsenNZ opened a new pull request, #24222:
URL: https://github.com/apache/superset/pull/24222
### SUMMARY
Render the correct hostname for the default postgres service.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
`Secret` resource:
<img width="322" alt="image" src="https://github.com/apache/superset/assets/10092581/4eb7fd0c-3b88-4aea-9e15-6904433a003f">
`Service` resources:
<img width="515" alt="image" src="https://github.com/apache/superset/assets/10092581/debd71a5-c1c0-4a6d-b862-bf07c7ae19e3">
### TESTING INSTRUCTIONS
```sh
helm upgrade --install my-release ~/dev/github.com/apache/superset/helm/superset --namespace default
```
```sh
helm upgrade --install my-release ~/dev/github.com/apache/superset/helm/superset --namespace default --set nameOverride="foo" --set fullnameOverride="bar"
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #24218
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NickLarsenNZ commented on pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "NickLarsenNZ (via GitHub)" <gi...@apache.org>.
NickLarsenNZ commented on PR #24222:
URL: https://github.com/apache/superset/pull/24222#issuecomment-1568179853
Good to go now @craig-rueda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NickLarsenNZ commented on pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "NickLarsenNZ (via GitHub)" <gi...@apache.org>.
NickLarsenNZ commented on PR #24222:
URL: https://github.com/apache/superset/pull/24222#issuecomment-1564113564
> Missing version bump and readme rebuild
@craig-rueda this has been done now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NickLarsenNZ commented on a diff in pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "NickLarsenNZ (via GitHub)" <gi...@apache.org>.
NickLarsenNZ commented on code in PR #24222:
URL: https://github.com/apache/superset/pull/24222#discussion_r1207061237
##########
helm/superset/Chart.yaml:
##########
@@ -15,7 +15,7 @@
# limitations under the License.
#
apiVersion: v2
-appVersion: "2.1.0"
+appVersion: "2.1.1"
Review Comment:
@craig-rueda I see I have updated the wrong version. Glad these checks are in place.
I'll fix tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NickLarsenNZ commented on a diff in pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "NickLarsenNZ (via GitHub)" <gi...@apache.org>.
NickLarsenNZ commented on code in PR #24222:
URL: https://github.com/apache/superset/pull/24222#discussion_r1209183371
##########
helm/superset/Chart.yaml:
##########
@@ -15,7 +15,7 @@
# limitations under the License.
#
apiVersion: v2
-appVersion: "2.1.0"
+appVersion: "2.1.1"
Review Comment:
@craig-rueda that's fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Lucasbousty commented on pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "Lucasbousty (via GitHub)" <gi...@apache.org>.
Lucasbousty commented on PR #24222:
URL: https://github.com/apache/superset/pull/24222#issuecomment-1578273385
I’m interested in some sexy pics and ready to be pay for feet pics amount can we Chat better on k..I..k or s.n a p. Feetbuyer204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #24222:
URL: https://github.com/apache/superset/pull/24222#issuecomment-1564650929
Looks like there's still a linter error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #24222: fix(helm): Use correct default hostnames for postgres and redis
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #24222:
URL: https://github.com/apache/superset/pull/24222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org