You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "platoneko (via GitHub)" <gi...@apache.org> on 2023/02/23 08:17:03 UTC
[GitHub] [doris] platoneko opened a new pull request, #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
platoneko opened a new pull request, #17069:
URL: https://github.com/apache/doris/pull/17069
# Proposed changes
Issue Number: close #xxx
## Problem summary
Rewrite `EngineCloneTask::_finish_full_clone` and `Tablet::revise_tablet_meta` to satisfy "cooldowned rowsets MUST be continuous" after tablet full clone.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17069:
URL: https://github.com/apache/doris/pull/17069#issuecomment-1447477946
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #17069:
URL: https://github.com/apache/doris/pull/17069#issuecomment-1441757209
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.72 seconds
stream load tsv: 467 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230223131251_clickbench_pr_102643.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #17069:
URL: https://github.com/apache/doris/pull/17069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17069:
URL: https://github.com/apache/doris/pull/17069#issuecomment-1447477991
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #17069:
URL: https://github.com/apache/doris/pull/17069#discussion_r1115358036
##########
be/src/olap/tablet.cpp:
##########
@@ -431,6 +383,7 @@
}
void Tablet::delete_rowsets(const std::vector<RowsetSharedPtr>& to_delete, bool move_to_stale) {
+ if (to_delete.empty()) return;
Review Comment:
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (to_delete.empty()) { return;
}
```
##########
be/src/olap/tablet.cpp:
##########
@@ -420,6 +371,7 @@ Status Tablet::modify_rowsets(std::vector<RowsetSharedPtr>& to_add,
}
void Tablet::add_rowsets(const std::vector<RowsetSharedPtr>& to_add) {
+ if (to_add.empty()) return;
Review Comment:
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (to_add.empty()) { return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #17069: [fix](cooldown) Handle full clone with cooldowned rowsets
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #17069:
URL: https://github.com/apache/doris/pull/17069#issuecomment-1441643557
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org