You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/23 14:11:40 UTC
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12007: ARROW-15087: [Python][Docs] Document MapArray and update parent class to ListArray
jorisvandenbossche commented on a change in pull request #12007:
URL: https://github.com/apache/arrow/pull/12007#discussion_r774594391
##########
File path: docs/source/python/data.rst
##########
@@ -264,6 +270,32 @@ individual arrays, and no copy is involved:
arr.type
arr
+Map arrays
+~~~~~~~~~~
+
+MapArrays can be constructed from lists of lists of tuples (key-item pairs), but only if
+the type is explicitly passed into :py:meth:`array`:
Review comment:
Not that important, but I _think_ you don't need the :py: in all those cases, since the "currentmodule" is pyarrow, so that should be searched first.
##########
File path: docs/source/python/data.rst
##########
@@ -264,6 +270,32 @@ individual arrays, and no copy is involved:
arr.type
arr
+Map arrays
+~~~~~~~~~~
+
+MapArrays can be constructed from lists of lists of tuples (key-item pairs), but only if
Review comment:
```suggestion
Map arrays can be constructed from lists of lists of tuples (key-item pairs), but only if
```
? We're not really consistent, but in the sections above (and also the "Map arrays" title) we typically use the prose "struct array" and not the class name "StructArray"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org