You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/04/25 22:52:43 UTC

[GitHub] [incubator-pinot] kishoreg commented on pull request #5293: Adding support for Protobuf input format

kishoreg commented on pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293#issuecomment-619451095


   > Should I also make changes in org.apache.pinot.hadoop.job.mappers.SegmentCreationMapper to pass custom Reader config as it is currently done for CSV and Thrift.
   
   I think that's deprecated and all configurations will go through SegmentGenerationJobSpec. https://github.com/apache/incubator-pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/RecordReaderSpec.java
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org