You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Stephen Connolly <st...@gmail.com> on 2010/08/05 16:21:56 UTC
Where is maven-toolchain for M3?
Where is maven-toolchain... the last one I can find in SVN:
https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no
3.0-beta-1 release...
http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
So where is it gone to?
-Stephen
Re: Where is maven-toolchain for M3?
Posted by Stephen Connolly <st...@gmail.com>.
OK, I can see:
------------------------------------------------------------------------
r789006 | bentmann | 2009-06-27 19:18:46 +0100 (Sat, 27 Jun 2009) | 1 line
Changed paths:
M /maven/components/trunk/apache-maven/pom.xml
M /maven/components/trunk/maven-core/pom.xml
M
/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
A
/maven/components/trunk/maven-core/src/main/java/org/apache/maven/toolchain
(from
/maven/components/trunk/maven-toolchain/src/main/java/org/apache/maven/toolchain:789000)
A /maven/components/trunk/maven-core/src/main/mdo/toolchains.mdo (from
/maven/components/trunk/maven-toolchain/src/main/mdo/toolchains.mdo:789000)
A
/maven/components/trunk/maven-core/src/test/java/org/apache/maven/toolchain
(from
/maven/components/trunk/maven-toolchain/src/test/java/org/apache/maven/toolchain:789000)
M /maven/components/trunk/maven-embedder/pom.xml
D /maven/components/trunk/maven-toolchain
M /maven/components/trunk/pom.xml
So Benjamin, where did it go?
-Stephen
On 5 August 2010 15:21, Stephen Connolly <st...@gmail.com>wrote:
> Where is maven-toolchain... the last one I can find in SVN:
> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
>
> repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no
> 3.0-beta-1 release...
> http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
>
> So where is it gone to?
>
> -Stephen
>
Re: Where is maven-toolchain for M3?
Posted by Stephen Connolly <st...@gmail.com>.
Or should I just create a new component for to hold toolchains and their
factories... that way if multiple plugins need the same non-core toolchains,
at least there is only one dependency that is needed.
I'm looking at MINVOKER-100 and the supplied patch does not smell good to
me, so I'm thinking I need to create maven-toolchain-maven as a project and
have the DefaultMavenToolchainFactory and DefaultMavenToolchain in that
project rather than end up with 5 or 6 different plugins all having the
same/similar duplicate code.
Also in that view the DefaultJavaToolchain should probably have been/be
removed from core (in an ideal world) to make it more easily extended
-Stephen
On 5 August 2010 15:27, Stephen Connolly <st...@gmail.com>wrote:
> Hmmmm
>
> So if I want to add more core toolchains I now have to push the changes to
> core, or will the classloader always take from core and not from a newer
> maven-toolchains dep of a plugin?
>
> -Stephen
>
>
> On 5 August 2010 15:25, Jason van Zyl <ja...@sonatype.com> wrote:
>
>>
>> https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/
>>
>> On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote:
>>
>> > Where is maven-toolchain... the last one I can find in SVN:
>> >
>> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
>> >
>> > repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no
>> > 3.0-beta-1 release...
>> > http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
>> >
>> > So where is it gone to?
>> >
>> > -Stephen
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>>
>> We know what we are, but know not what we may be.
>>
>> -- Shakespeare
>>
>>
>>
>>
>
Re: Where is maven-toolchain for M3?
Posted by Stephen Connolly <st...@gmail.com>.
I'll think about that overnight... and perhaps discuss with Benjamin the
implications on IRC tomorrow. If I feel it's better out I'll call a vote
first.
If we are taking it out I'd rather see it removed before 3.0-beta-2.
My thinking is that we remove the org.apache.maven.toolchain.java package
from core and leave the rest where it is.
My worries are the implications for plugins running against [2.0.9,3.0.0)
* If the plugin depends on the newer maven-toolchain-java artifact... will
life be ok
-Stephen
On 5 August 2010 15:33, Jason van Zyl <ja...@sonatype.com> wrote:
> Maybe just decouple it completely from the core if you think it's going to
> vary that much.
>
> I would be for completely extracting it.
>
> On Aug 5, 2010, at 10:27 AM, Stephen Connolly wrote:
>
> > Hmmmm
> >
> > So if I want to add more core toolchains I now have to push the changes
> to
> > core, or will the classloader always take from core and not from a newer
> > maven-toolchains dep of a plugin?
> >
> > -Stephen
> >
> > On 5 August 2010 15:25, Jason van Zyl <ja...@sonatype.com> wrote:
> >
> >>
> >>
> https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/
> >>
> >> On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote:
> >>
> >>> Where is maven-toolchain... the last one I can find in SVN:
> >>>
> >>
> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
> >>>
> >>> repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but
> no
> >>> 3.0-beta-1 release...
> >>> http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
> >>>
> >>> So where is it gone to?
> >>>
> >>> -Stephen
> >>
> >> Thanks,
> >>
> >> Jason
> >>
> >> ----------------------------------------------------------
> >> Jason van Zyl
> >> Founder, Apache Maven
> >> http://twitter.com/jvanzyl
> >> ---------------------------------------------------------
> >>
> >> We know what we are, but know not what we may be.
> >>
> >> -- Shakespeare
> >>
> >>
> >>
> >>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
> To do two things at once is to do neither.
>
> -—Publilius Syrus, Roman slave, first century B.C.
>
>
>
>
Re: Where is maven-toolchain for M3?
Posted by Jason van Zyl <ja...@sonatype.com>.
Maybe just decouple it completely from the core if you think it's going to vary that much.
I would be for completely extracting it.
On Aug 5, 2010, at 10:27 AM, Stephen Connolly wrote:
> Hmmmm
>
> So if I want to add more core toolchains I now have to push the changes to
> core, or will the classloader always take from core and not from a newer
> maven-toolchains dep of a plugin?
>
> -Stephen
>
> On 5 August 2010 15:25, Jason van Zyl <ja...@sonatype.com> wrote:
>
>>
>> https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/
>>
>> On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote:
>>
>>> Where is maven-toolchain... the last one I can find in SVN:
>>>
>> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
>>>
>>> repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no
>>> 3.0-beta-1 release...
>>> http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
>>>
>>> So where is it gone to?
>>>
>>> -Stephen
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>>
>> We know what we are, but know not what we may be.
>>
>> -- Shakespeare
>>
>>
>>
>>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
To do two things at once is to do neither.
-—Publilius Syrus, Roman slave, first century B.C.
Re: Where is maven-toolchain for M3?
Posted by Stephen Connolly <st...@gmail.com>.
I don't think org.apache.maven.toolchain.java should ever have been in
maven-toolchain, it should have lived in its own artifact.
maven-toolchain was tied to core, and AFAIK the core classloader will always
win in such cases, so the net result is it is not possible to add the extra
methods that were planned for JavaToolChain, e.g. getBootstrapLibraries(),
etc [not that those methods are necessarily the ones we'd want]
Still, we have org.apache.maven.toolchain.java in core and in
maven-toolchain, but I would like to extend it... except that it basically
forces a new version of maven to be able to do that, or else we have a new
set of classes, e.g. org.apache.maven.toolchain.jdk which duplicate what is
in core but add the extras and mark the stuff in
org.apache.maven.toolchain.java as deprecated
-Stephen
On 5 August 2010 15:37, Benjamin Bentmann <be...@udo.edu> wrote:
> Stephen Connolly wrote:
>
> So if I want to add more core toolchains I now have to push the changes to
>> core, or will the classloader always take from core and not from a newer
>> maven-toolchains dep of a plugin?
>>
>
> Not sure what you mean with "core toolchain" here, at least in M3 you
> should be free to add new toolchains as plugin dependencies or build
> extensions dependending on the scope of use.
>
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Where is maven-toolchain for M3?
Posted by Benjamin Bentmann <be...@udo.edu>.
Stephen Connolly wrote:
> So if I want to add more core toolchains I now have to push the changes to
> core, or will the classloader always take from core and not from a newer
> maven-toolchains dep of a plugin?
Not sure what you mean with "core toolchain" here, at least in M3 you
should be free to add new toolchains as plugin dependencies or build
extensions dependending on the scope of use.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Where is maven-toolchain for M3?
Posted by Stephen Connolly <st...@gmail.com>.
Hmmmm
So if I want to add more core toolchains I now have to push the changes to
core, or will the classloader always take from core and not from a newer
maven-toolchains dep of a plugin?
-Stephen
On 5 August 2010 15:25, Jason van Zyl <ja...@sonatype.com> wrote:
>
> https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/
>
> On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote:
>
> > Where is maven-toolchain... the last one I can find in SVN:
> >
> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
> >
> > repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no
> > 3.0-beta-1 release...
> > http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
> >
> > So where is it gone to?
> >
> > -Stephen
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
> We know what we are, but know not what we may be.
>
> -- Shakespeare
>
>
>
>
Re: Where is maven-toolchain for M3?
Posted by Jason van Zyl <ja...@sonatype.com>.
https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/
On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote:
> Where is maven-toolchain... the last one I can find in SVN:
> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain
>
> repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no
> 3.0-beta-1 release...
> http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/
>
> So where is it gone to?
>
> -Stephen
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
We know what we are, but know not what we may be.
-- Shakespeare
Re: Where is maven-toolchain for M3?
Posted by Benjamin Bentmann <be...@udo.edu>.
Stephen Connolly wrote:
> Where is maven-toolchain...
maven-core
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org