You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ariel Weisberg (JIRA)" <ji...@apache.org> on 2018/02/09 17:31:00 UTC
[jira] [Commented] (CASSANDRA-14225) fix comparison of address and
port for repair and messages
[ https://issues.apache.org/jira/browse/CASSANDRA-14225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358737#comment-16358737 ]
Ariel Weisberg commented on CASSANDRA-14225:
--------------------------------------------
Did you want me as the reviewer or assignee?
{{FBUtilities.getBroadcastNativeAddressAndPort()}} is for the port used by the CQL protocol. Maybe we should javadoc that. You want {{FBUtilities.getBroadcastAddressAndPort()}} for the storage port. There is a missing newline between the new import and the start of the class comments.
In RepairRunnable the diff introduces a tab when constructing the InetAddressAndPort.
Otherwise +1.
> fix comparison of address and port for repair and messages
> ----------------------------------------------------------
>
> Key: CASSANDRA-14225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14225
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Dave Brosius
> Assignee: Ariel Weisberg
> Priority: Trivial
> Fix For: 4.0
>
> Attachments: 14225.txt
>
>
> compare both host and port, not just host
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org