You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/31 12:13:04 UTC
[jira] [Commented] (FLINK-6752) Activate strict checkstyle for
flink-core
[ https://issues.apache.org/jira/browse/FLINK-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031068#comment-16031068 ]
ASF GitHub Bot commented on FLINK-6752:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4027
[FLINK-6752] Apply non-invasive checkstyle rules to flink-core
This PR applies 3 non-invasive checkstyle rules to flink-core. It reorders imports, adds an empty line before the package declaration and removes multiple subsequent empty lines.
Note that the actual checkstyle enforcement in flink-core wasn't changed. The above checks should be added to the default checkstyle once we've applied PRs like this for the remaining modules.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6752cscore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4027
----
commit 9e0b54188dbd3e6125204b036f87344d0496d01f
Author: zentol <ch...@apache.org>
Date: 2017-05-31T11:56:45Z
imports generated
commit 3c10edf5d6e9641cdff95dc8daa6471cc003170f
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:01:52Z
imports /main
commit 68e93bef2cd22a919777c4fa4f659acee9436a97
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:02:14Z
imports /test
commit 2f765f00f482057a7e8e56c5875318c563525fcc
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:04:19Z
add missing line before package
commit 63dff16ec125a614e7b9054dd95f92d63429863c
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:06:47Z
multi-empty line generated
commit 7592b91875fc0bfa613a7f5118b2b99cac6f89e6
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:11:03Z
multi-empty line /main
commit fdfe2288bdcd3c76c64cd3e56a1b5323c433bfc2
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:11:16Z
multi-empty line /test
----
> Activate strict checkstyle for flink-core
> -----------------------------------------
>
> Key: FLINK-6752
> URL: https://issues.apache.org/jira/browse/FLINK-6752
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Long term issue for incrementally introducing the strict checkstyle to flink-core.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)