You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2012/09/26 06:38:09 UTC
[jira] [Created] (GIRAPH-346) Top Level POM
Nitay Joffe created GIRAPH-346:
----------------------------------
Summary: Top Level POM
Key: GIRAPH-346
URL: https://issues.apache.org/jira/browse/GIRAPH-346
Project: Giraph
Issue Type: Improvement
Reporter: Nitay Joffe
Priority: Minor
Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469024#comment-13469024 ]
Avery Ching commented on GIRAPH-346:
------------------------------------
I like this change. Anyone else have comments?
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463519#comment-13463519 ]
Avery Ching commented on GIRAPH-346:
------------------------------------
I think this is good, how long does it take to build the formats? Would be great to have the default build only giraph and then add an option to build the formats, but for commits we could try to build everything.
Would like to hear what others think.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe reassigned GIRAPH-346:
----------------------------------
Assignee: Nitay Joffe
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475234#comment-13475234 ]
Hudson commented on GIRAPH-346:
-------------------------------
Integrated in Giraph-trunk-Commit #236 (See [https://builds.apache.org/job/Giraph-trunk-Commit/236/])
GIRAPH-346: Top Level POM. (nitay via aching) (Revision 1397678)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397678
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/README
* /giraph/trunk/giraph
* /giraph/trunk/giraph-formats-contrib/pom.xml
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hbase/HBaseVertexInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hbase/HBaseVertexOutputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java
* /giraph/trunk/giraph/pom.xml
* /giraph/trunk/giraph/src
* /giraph/trunk/pom.xml
* /giraph/trunk/src
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346-2.patch, GIRAPH-346-3.patch, GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463527#comment-13463527 ]
Nitay Joffe commented on GIRAPH-346:
------------------------------------
This is output of 'time mvn clean verify' in giraph-formats-contrib:
real 2m38.763s
user 1m41.244s
sys 0m13.127s
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464321#comment-13464321 ]
Nitay Joffe commented on GIRAPH-346:
------------------------------------
You're right that if you changed something in giraph-main you would have to do an install first to make formats compile correctly. I was actually wondering if other multi-module maven projects have a quick way around this (using the raw source everywhere instead of compiling against jars at all), but it seems like this is actually the standard practice?
Also we should get our CI building SNAPSHOT jars on every commit. Has this been discussed or should I open up an issue?
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-346:
-------------------------------
Attachment: GIRAPH-346-2.patch
Yeah that patch is out of date now. Here's a rebased version, try this one out.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346-2.patch, GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463564#comment-13463564 ]
Brian Femiano commented on GIRAPH-346:
--------------------------------------
For faster development turnaround this would be crucial. Users must still remember to 'mvn clean install' from the parent pom, otherwise formats-contrib will not utilize the latest changes. Running mvn clean package won't cut it, at least until we push artifacts to a known repo. I agree for everyday operations it would be smoother.
Often I wonder if format-contrib is advertised well enough to newer users. Have a base build with a parent would help this. I'm all for it.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-346:
-------------------------------
Attachment: readme.patch
Diff for readme. Let me know if you want further explanations?
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470891#comment-13470891 ]
Eugene Koontz commented on GIRAPH-346:
--------------------------------------
I don't think this patch needs to be blocked by GIRAPH-211. As big as this restructuring is, I can rewrite the GIRAPH-211 patch to match it.
However, the current patch here fails when I try to apply it to trunk. One problem I noticed is that the munge flag {{HADOOP_NON_SASL_RPC}} is used - it should no longer be used; it was removed by GIRAPH-212 which is now committed to trunk.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-346:
-------------------------------
Attachment: GIRAPH-346-3.patch
Rebased after GIRAPH-211. Works for me on all profiles.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346-2.patch, GIRAPH-346-3.patch, GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-346:
-------------------------------
Attachment: (was: readme.patch)
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346-2.patch, GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463562#comment-13463562 ]
Eugene Koontz commented on GIRAPH-346:
--------------------------------------
I think it's worth exploring. We might refer to HBase's experiences with the same journey that they took, starting with Gary Helmling's work on security, to a more modular pom.xml:
https://issues.apache.org/jira/browse/HBASE-4336
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470828#comment-13470828 ]
Avery Ching commented on GIRAPH-346:
------------------------------------
Should we wait until GIRAPH-211 is committed?
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468281#comment-13468281 ]
Avery Ching commented on GIRAPH-346:
------------------------------------
Nitay can you describe how the build process now works with your changes? How do we build only giraph and then build the contribs?
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474541#comment-13474541 ]
Avery Ching commented on GIRAPH-346:
------------------------------------
+1, passed mvn clean install for me.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346-2.patch, GIRAPH-346-3.patch, GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463526#comment-13463526 ]
Nitay Joffe commented on GIRAPH-346:
------------------------------------
Yeah we can do that, but I think if you want to just build giraph-main you can just go into that subdirectory and do all your work there, no? Anyways I can add a profile for that part if that is what you guys prefer, but I actually think it's better to make it by default build everything so that when anyone checks in code they run mvn clean verify at top level and it verifies everything.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Minor
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475233#comment-13475233 ]
Avery Ching commented on GIRAPH-346:
------------------------------------
committed.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346-2.patch, GIRAPH-346-3.patch, GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-346:
-------------------------------
Attachment: GIRAPH-346.patch
Here's first stab at this. There should be no logic change here.
The main module is under giraph, as I wanted to keep the module names the same as the artifactId. We might want to change these to something else like giraph-main, giraph-formats?
The main sources are copied from src/ to giraph/src.
The top level POM contains as much common settings as I could put in.
This passes mvn clean verify.
https://reviews.apache.org/r/7404/
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-346) Top Level POM
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469252#comment-13469252 ]
Nitay Joffe commented on GIRAPH-346:
------------------------------------
Note after we commit this we should publish everything to maven repository because even giraph-main will look for the parent giraph project pom. Having a parent in maven puts in an implicit dependency. This is easy to manage as it should mean just running "mvn deploy" at the top level.
> Top Level POM
> -------------
>
> Key: GIRAPH-346
> URL: https://issues.apache.org/jira/browse/GIRAPH-346
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a top level pom.xml. This allows you avoid redundancy and also to build everything from top level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira