You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by laxatives <gi...@git.apache.org> on 2015/12/09 22:45:16 UTC

[GitHub] incubator-tinkerpop pull request: Support self-looping edges in Gr...

GitHub user laxatives opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175

    Support self-looping edges in GraphSONReader

    I haven't really investigated this very thoroughly, but I'm having an issue reading self-looping edges  from GraphSON. From what I've gathered, GraphSON Reader traverses edges from their source while the Writer only creates a single edge directional edge in to the destination vertex. 
    
    Reproduction here: https://groups.google.com/forum/#!topic/gremlin-users/EU1OFBCIbDk

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laxatives/incubator-tinkerpop master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #175
    
----
commit 1892d7c70f18bd2b3c38eb6ac1e051c89d1aa326
Author: Benjamin Han <be...@siftsec.com>
Date:   2015-12-09T21:24:22Z

    Support self-looping edges in GraphSONReader

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-163454728
  
    Done. This does not appear to be an issue for the gryo or GraphML


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-164073855
  
    Sounds great. Is there any reason the GraphSONReader/Writer would behave differently from the test environment and gremlin.sh? I'm fairly certain I am failing the case above (read graph only has 1 edge) while executing from gremlin.sh. This issue came up because I am converting a graph into a gson file for every vertex and for every edge, but self edges are consistently missing. I have been working off of tp31, but this still occurs in gremlin.sh of the master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-167622062
  
    From what I can tell from the code in this PR, there is nothing "too crazy" here save that you assume incoming edges and not outgoing edges, where outgoing edges are the typical "lowest common denominator" for a format. That is, most people, if they don't have the full "star graph" will have at least outgoing edges for each vertex (NOT incoming edges). I don't know why you require incoming edges, but okay... I assume you have your reasons. If you can make it work without that assumption, that would be best (I suppose).
    
    Next, I don't know how `StarGraph` plays into this. Is `StarGraph` failing with self-loops? `StarGraph` is serialized via `Gryo` (see `VertexWritable` as well). If GryoReader/Writer is happy, then I suspect things will work with all the Hadoop/Spark/etc. work. However, it would be best if we had some self-loop tests. What sucks is we don't have a `GraphLoader.SELF_LOOPS` style toy dataset and with `HadoopGraph`, you can't mutate the graph............................. 
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-163924998
  
    I've found that with IO tests you can't assume too much.  Asserting counts isn't quite enough.  I would assert the edge labels as well as direction of the edges after the read. I like this set of tests you've added btw - still not convinced there's a problem in the `GraphSONReader` that needs to be fixed, but I'd like to merge in the tests regardless of the ultimate finding there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-164091767
  
    fwiw, here's the GraphSON output that shows the single ouE:
    
    ```js
    {"id":0,"label":"vertex","inE":{"SELF-LOOP":[{"id":3,"outV":0}]},"outE":{"CONTROL":[{"id":2,"inV":1}]}}
    {"id":1,"label":"vertex","inE":{"CONTROL":[{"id":2,"outV":0}]}}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-164090851
  
    Sounds right, but I think we need to think through the wider implications this change would have.  `StarGraph` is central to a lot of stuff that happens in OLAP traversals.  We could use some guidance from @okram but i believe he's started his holiday break at this point.  This might have to sit a bit until he's back online.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-168053374
  
    Well, `StarGraph` does use `GryoReader/Writer` to do its thing. So Hadoop/Spark/Giraph will rely on these reader/writers. If everything passes then we should be good (however, do make sure integration tests pass as that is the Hadoop scene).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-163689530
  
    Yeah you're right, the tests pass in both branches. Looks like I'm comparing two streams and this always returns true? Is that reasonable behavior? Would it make more sense for streams to check reference equality, or possibly equality of their contents?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-163658527
  
    I'm not sure what to make of this, but I looked at the code for writing and I don't think i agree with your assessment that:
    
    >  Writer only creates a single directional edge in the destination vertex.
    
    as a test, I tried out the tests that you added to `IoTest`.  They pass for me with AND without your change to the `GraphSONReader`.  In other words, I can set that value to `IN` or `OUT` and the tests pass. Does that happen for you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170896458
  
    I tried to run the integration tests last night and they failed for Neo4j.  I think it's due to a problem in how Neo4j's `GraphProvider` implementations were working.  I just pushed this fix to master (as of this moment this change hasn't mirrored to github yet):
    
    https://git-wip-us.apache.org/repos/asf?p=incubator-tinkerpop.git;a=commit;h=b02b9f82728960c805b9a663e34fa9a71010a75f
    
    I suggest you merge that change and see if that gets things working for neo4j as you continue to try to run the tests.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170595818
  
    Sorry, I've been out of town for the past few weeks. Are there any more actionable items for this PR? Can I run integration tests, or is this something in TinkerPop's court?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#discussion_r47421541
  
    --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java ---
    @@ -249,6 +250,63 @@ public void shouldProperlyEncodeWithGraphML() throws Exception {
                 // need to manually close the "g2" instance
                 graphProvider.clear(g2, configuration);
             }
    +
    +        @Test
    +        @FeatureRequirement(featureClass = Graph.Features.EdgeFeatures.class, feature = Graph.Features.EdgeFeatures.FEATURE_ADD_EDGES)
    +        @FeatureRequirement(featureClass = EdgePropertyFeatures.class, feature = FEATURE_STRING_VALUES)
    +        @FeatureRequirement(featureClass = Graph.Features.VertexFeatures.class, feature = Graph.Features.VertexFeatures.FEATURE_ADD_VERTICES)
    +        public void shouldReadWriteSelfLoopingEdges() throws Exception {
    +            final Configuration sourceConf = graphProvider.newGraphConfiguration("source", this.getClass(), name.getMethodName(), null);
    +            final Graph source = GraphFactory.open(sourceConf);
    +            final Vertex v1 = source.addVertex();
    +            final Vertex v2 = source.addVertex();
    +            v1.addEdge("CONTROL", v2);
    +            v1.addEdge("SELF-LOOP", v1);
    +
    +            final Configuration targetConf = graphProvider.newGraphConfiguration("target", this.getClass(), name.getMethodName(), null);
    +            final Graph target = GraphFactory.open(targetConf);
    +            try (ByteArrayOutputStream os = new ByteArrayOutputStream()) {
    +                source.io(IoCore.graphml()).writer().create().writeGraph(os, source);
    +                try (ByteArrayInputStream is = new ByteArrayInputStream(os.toByteArray())) {
    +                    target.io(IoCore.graphml()).reader().create().readGraph(is, target);
    +                }
    +            } catch (IOException ioe) {
    +                throw new RuntimeException(ioe);
    +            }
    +
    +            assertEquals(IteratorUtils.count(source.vertices()), IteratorUtils.count(target.vertices()));
    +            assertEquals(IteratorUtils.count(source.edges()), IteratorUtils.count(target.vertices()));
    --- End diff --
    
    i bet this is why your test passes................. you are counting "source" edges against "target" vertices.  those counts happen to match. the assert is bad.  and yeah, now i see where the self-relation is only written on "inE" which is why it won't get read on "outE".  Given that we know your asserts are off, please double check gryo/graphml now and be sure those are passing too.
    
    as for why, it doesn't write the edge for both "outE" and "inE" - it just seems to be the way the `StarGraph` is implemented.  I sense that we call `addEdge()` on `StarGraph` which in turn chooses to call `addOutEdge` so it only gets added as an "out" edge.  Not sure what the implications of that are.  
    
    @okram not sure if we need to do anything with that in `StarGraph` but something to be aware of with self-relations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-171052248
  
    VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-164090219
  
    Yes, this failed for both GraphSON and Gryo (but NOT GraphML) in master:
    
    ```Tests run: 796, Failures: 2, Errors: 0, Skipped: 214, Time elapsed: 8.361 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraphStructureStandardTest
    shouldReadWriteSelfLoopingEdges(org.apache.tinkerpop.gremlin.structure.io.IoTest$GraphSONTest)  Time elapsed: 0.01 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<2> but was:<1>
            at org.junit.Assert.fail(Assert.java:88)
            at org.junit.Assert.failNotEquals(Assert.java:834)
            at org.junit.Assert.assertEquals(Assert.java:645)
            at org.junit.Assert.assertEquals(Assert.java:631)
            at org.apache.tinkerpop.gremlin.structure.io.IoTest$GraphSONTest.shouldReadWriteSelfLoopingEdges(IoTest.java:457)
    
    shouldReadWriteSelfLoopingEdges(org.apache.tinkerpop.gremlin.structure.io.IoTest$GryoTest)  Time elapsed: 0.005 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<2> but was:<1>
            at org.junit.Assert.fail(Assert.java:88)
            at org.junit.Assert.failNotEquals(Assert.java:834)
            at org.junit.Assert.assertEquals(Assert.java:645)
            at org.junit.Assert.assertEquals(Assert.java:631)
            at org.apache.tinkerpop.gremlin.structure.io.IoTest$GryoTest.shouldReadWriteSelfLoopingEdges(IoTest.java:308)
    ```
    
    If GraphSONReader assumes that for every edge E, E.outV().edges().contains(E), it seems reasonable that that assumption could have propagated to other places. Maybe its better to include self edges in both edges(OUT) and edges(IN)? This would also ensure that every graph G has G.V().edgesOut().count() + G.V().edgesIn().count() == 2 * G.edges().count(), which is clearly not the case now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-168050771
  
    @spmallette If you feel we have sufficient test cases for this work, then okay. +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170734170
  
    Giraph always fails on the first connection attempt to ZooKeeper. Thus, ignore it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-171024783
  
    Thanks Stephen.
    
    Integration test `BUILD SUCCESSFUL`.
    
    ```
    mvn clean install -DskipIntegrationTests=false -DincludeNeo4j
    ...
    [INFO] Reactor Summary:
    [INFO] 
    [INFO] Apache TinkerPop ................................... SUCCESS [  7.636 s]
    [INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  4.199 s]
    [INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [01:42 min]
    [INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 29.099 s]
    [INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 42.608 s]
    [INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [  7.104 s]
    [INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [03:53 min]
    [INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [06:17 min]
    [INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [04:56 min]
    [INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [  02:02 h]
    [INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [23:01 min]
    [INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 16.517 s]
    [INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [11:46 min]
    [INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [01:21 min]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 02:56 h
    [INFO] Finished at: 2016-01-12T11:20:45-08:00
    [INFO] Final Memory: 104M/765M
    [INFO] ------------------------------------------------------------------------
    ```
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#discussion_r49443884
  
    --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java ---
    @@ -249,6 +250,63 @@ public void shouldProperlyEncodeWithGraphML() throws Exception {
                 // need to manually close the "g2" instance
                 graphProvider.clear(g2, configuration);
             }
    +
    +        @Test
    +        @FeatureRequirement(featureClass = Graph.Features.EdgeFeatures.class, feature = Graph.Features.EdgeFeatures.FEATURE_ADD_EDGES)
    +        @FeatureRequirement(featureClass = EdgePropertyFeatures.class, feature = FEATURE_STRING_VALUES)
    +        @FeatureRequirement(featureClass = Graph.Features.VertexFeatures.class, feature = Graph.Features.VertexFeatures.FEATURE_ADD_VERTICES)
    +        public void shouldReadWriteSelfLoopingEdges() throws Exception {
    +            final Configuration sourceConf = graphProvider.newGraphConfiguration("source", this.getClass(), name.getMethodName(), null);
    --- End diff --
    
    @laxatives you don't need to create a new graph here as you get one for free by virtue of starting a test.  Just assign the "graph" variable to your "source" variable on the line below.  please do that for the other tests as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-168032109
  
    I don't think that anything is failing with `StarGraph`.  I just wanted to be sure that we were ok with leaving things as they are with this change (i.e. write/read self-loops on the "in" edges and not writing them on the "out" edges at all).  If we kept it that way, I'd probably just add something to the documentation to point that issue out.
    
    @okram if that makes sense to you and others voting, then i'm +1 for merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-168052076
  
    i believe the tests are good - the old tests pass and @laxatives has added "self-loop" tests - something we didn't have before. This also only affects calls to `read/writeGraph` from `io()` so i wouldn't expect that to be trouble to hadoop/spark stuff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Support self-looping edges in Gr...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-163424486
  
    hmm - i suppose it makes sense that this slipped through as we clearly don't have tests for self-loops.  
    
    I've created a JIRA issue for this: https://issues.apache.org/jira/browse/TINKERPOP-1036
    
    Unfortunately changes to IO are never terribly simple.  It will probably take a little back and forth discussion to cover all the bases...do you mind doing a little more legwork to get this PR ready to merge?  if so....
    
    can you please rename your PR to reference: TINKERPOP-1036 at the start of the title so that it will hook into our workflow?
    
    Next, my first question is whether or not you've determined if this a problem for our other two IO formats: gryo and graphson?
    
    finally, please move the test you did add to:
    
    https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java#L254
    
    I think that's the best place for it for right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-171068938
  
    Although it's already merged ...
    
    * `mvn clean install`: passed
    
    ... hence, here's the missing "official" VOTE: +1 (binding)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170728339
  
    Thanks. Not sure if this is due to the changes in this PR or my environment, but I'm still having some issues with ConnectException. There's a lot of noise here, but it the test seems to keep retrying on "Make sure that the EdgeOutputFormat is not required" and consistently gets a "Connect refused" on the first attempt before connecting on the first retry. Here's a snippet of a the log. This pattern keeps repeating until I kill the test.
    
    ```
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Attempting to start ZooKeeper server with command [/usr/lib/jvm/sift-jdk1.8.0_66/jre/bin/java, -cp, /home/ben/incubator-tinkerpop/giraph-gremlin/target/test-classes:/home/ben/incubator-tinkerpop/giraph-gremlin/target/classes:/home/ben/incubator-tinkerpop/gremlin-core/target/gremlin-core-3.1.1-SNAPSHOT.jar:/home/ben/incubator-tinkerpop/gremlin-shaded/target/gremlin-shaded-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/commons-configuration/commons-configuration/1.10/commons-configuration-1.10.jar:/home/ben/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/ben/.m2/repository/org/yaml/snakeyaml/1.15/snakeyaml-1.15.jar:/home/ben/.m2/repository/org/javatuples/javatuples/1.2/javatuples-1.2.jar:/home/ben/.m2/repository/com/carrotsearch/hppc/0.7.1/hppc-0.7.1.jar:/home/ben/.m2/repository/com/jcabi/jcabi-manifests/1.1/jcabi-manifests-1.1.jar:/home/ben/.m2/repository/com/jcabi/jcabi-log/0.14/jcabi-log-
 0.14.jar:/home/ben/.m2/repository/org/slf4j/slf4j-log4j12/1.7.12/slf4j-log4j12-1.7.12.jar:/home/ben/.m2/repository/org/slf4j/slf4j-api/1.7.12/slf4j-api-1.7.12.jar:/home/ben/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/ben/.m2/repository/org/slf4j/jcl-over-slf4j/1.7.12/jcl-over-slf4j-1.7.12.jar:/home/ben/incubator-tinkerpop/gremlin-groovy/target/gremlin-groovy-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/org/apache/ivy/ivy/2.3.0/ivy-2.3.0.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy/2.4.5/groovy-2.4.5-indy.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-groovysh/2.4.5/groovy-groovysh-2.4.5-indy.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-console/2.4.5/groovy-console-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-templates/2.4.5/groovy-templates-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-xml/2.4.5/groovy-xml-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-swing/2.4.5/groovy-swing-2.4.5.jar:/home/
 ben/.m2/repository/jline/jline/2.12/jline-2.12.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy/2.4.5/groovy-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-json/2.4.5/groovy-json-2.4.5-indy.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-jsr223/2.4.5/groovy-jsr223-2.4.5-indy.jar:/home/ben/.m2/repository/org/apache/commons/commons-lang3/3.3.1/commons-lang3-3.3.1.jar:/home/ben/.m2/repository/org/mindrot/jbcrypt/0.3m/jbcrypt-0.3m.jar:/home/ben/incubator-tinkerpop/hadoop-gremlin/target/hadoop-gremlin-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-client/2.7.1/hadoop-client-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-common/2.7.1/hadoop-common-2.7.1.jar:/home/ben/.m2/repository/org/apache/commons/commons-math3/3.1.1/commons-math3-3.1.1.jar:/home/ben/.m2/repository/xmlenc/xmlenc/0.52/xmlenc-0.52.jar:/home/ben/.m2/repository/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar:/home/ben/.m2/repository/commo
 ns-io/commons-io/2.4/commons-io-2.4.jar:/home/ben/.m2/repository/commons-net/commons-net/3.1/commons-net-3.1.jar:/home/ben/.m2/repository/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar:/home/ben/.m2/repository/javax/servlet/jsp/jsp-api/2.1/jsp-api-2.1.jar:/home/ben/.m2/repository/org/apache/avro/avro/1.7.4/avro-1.7.4.jar:/home/ben/.m2/repository/com/google/protobuf/protobuf-java/2.5.0/protobuf-java-2.5.0.jar:/home/ben/.m2/repository/com/google/code/gson/gson/2.2.4/gson-2.2.4.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-auth/2.7.1/hadoop-auth-2.7.1.jar:/home/ben/.m2/repository/org/apache/httpcomponents/httpclient/4.2.5/httpclient-4.2.5.jar:/home/ben/.m2/repository/org/apache/httpcomponents/httpcore/4.2.4/httpcore-4.2.4.jar:/home/ben/.m2/repository/org/apache/directory/server/apacheds-kerberos-codec/2.0.0-M15/apacheds-kerberos-codec-2.0.0-M15.jar:/home/ben/.m2/repository/org/apache/directory/server/apacheds-i18n/2.0.0-M15/apacheds-i18n-2.0.0-M15.j
 ar:/home/ben/.m2/repository/org/apache/directory/api/api-asn1-api/1.0.0-M20/api-asn1-api-1.0.0-M20.jar:/home/ben/.m2/repository/org/apache/directory/api/api-util/1.0.0-M20/api-util-1.0.0-M20.jar:/home/ben/.m2/repository/org/apache/curator/curator-framework/2.7.1/curator-framework-2.7.1.jar:/home/ben/.m2/repository/org/apache/curator/curator-client/2.7.1/curator-client-2.7.1.jar:/home/ben/.m2/repository/org/apache/curator/curator-recipes/2.7.1/curator-recipes-2.7.1.jar:/home/ben/.m2/repository/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.jar:/home/ben/.m2/repository/org/apache/htrace/htrace-core/3.1.0-incubating/htrace-core-3.1.0-incubating.jar:/home/ben/.m2/repository/org/apache/commons/commons-compress/1.4.1/commons-compress-1.4.1.jar:/home/ben/.m2/repository/org/tukaani/xz/1.0/xz-1.0.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-hdfs/2.7.1/hadoop-hdfs-2.7.1.jar:/home/ben/.m2/repository/org/mortbay/jetty/jetty-util/6.1.26/jetty-util-6.1.26.jar:/home/ben/.m2/repository
 /xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar:/home/ben/.m2/repository/xml-apis/xml-apis/1.3.04/xml-apis-1.3.04.jar:/home/ben/.m2/repository/org/fusesource/leveldbjni/leveldbjni-all/1.8/leveldbjni-all-1.8.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-app/2.7.1/hadoop-mapreduce-client-app-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-common/2.7.1/hadoop-mapreduce-client-common-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-yarn-client/2.7.1/hadoop-yarn-client-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-yarn-server-common/2.7.1/hadoop-yarn-server-common-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-shuffle/2.7.1/hadoop-mapreduce-client-shuffle-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-yarn-api/2.7.1/hadoop-yarn-api-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-core/2.7.1/hadoop-mapreduce-client-core-2.7.1.jar:/home/ben/.m2
 /repository/org/apache/hadoop/hadoop-yarn-common/2.7.1/hadoop-yarn-common-2.7.1.jar:/home/ben/.m2/repository/javax/xml/bind/jaxb-api/2.2.2/jaxb-api-2.2.2.jar:/home/ben/.m2/repository/javax/xml/stream/stax-api/1.0-2/stax-api-1.0-2.jar:/home/ben/.m2/repository/javax/activation/activation/1.1/activation-1.1.jar:/home/ben/.m2/repository/com/sun/jersey/jersey-core/1.9/jersey-core-1.9.jar:/home/ben/.m2/repository/com/sun/jersey/jersey-client/1.9/jersey-client-1.9.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-jaxrs/1.9.13/jackson-jaxrs-1.9.13.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-xc/1.9.13/jackson-xc-1.9.13.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-jobclient/2.7.1/hadoop-mapreduce-client-jobclient-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-annotations/2.7.1/hadoop-annotations-2.7.1.jar:/home/ben/.m2/repository/commons-codec/commons-codec/1.6/commons-codec-1.6.jar:/home/ben/.m2/repository/commons-logging/commons-l
 ogging/1.1.3/commons-logging-1.1.3.jar:/home/ben/.m2/repository/com/google/guava/guava/16.0.1/guava-16.0.1.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-mapper-asl/1.9.13/jackson-mapper-asl-1.9.13.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-core-asl/1.9.13/jackson-core-asl-1.9.13.jar:/home/ben/.m2/repository/org/xerial/snappy/snappy-java/1.1.1.7/snappy-java-1.1.1.7.jar:/home/ben/.m2/repository/org/apache/giraph/giraph-core/1.1.0-hadoop2/giraph-core-1.1.0-hadoop2.jar:/home/ben/.m2/repository/com/facebook/nifty/nifty-client/0.13.1/nifty-client-0.13.1.jar:/home/ben/.m2/repository/com/facebook/nifty/nifty-core/0.13.1/nifty-core-0.13.1.jar:/home/ben/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar:/home/ben/.m2/repository/com/google/inject/extensions/guice-multibindings/3.0/guice-multibindings-3.0.jar:/home/ben/.m2/repository/com/google/inject/guice/3.0/guice-3.0.jar:/home/ben/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar:/home/ben/
 .m2/repository/io/airlift/units/0.91/units-0.91.jar:/home/ben/.m2/repository/javax/validation/validation-api/1.1.0.Final/validation-api-1.1.0.Final.jar:/home/ben/.m2/repository/io/netty/netty/3.7.0.Final/netty-3.7.0.Final.jar:/home/ben/.m2/repository/com/facebook/swift/swift-annotations/0.13.1/swift-annotations-0.13.1.jar:/home/ben/.m2/repository/com/facebook/swift/swift-codec/0.13.1/swift-codec-0.13.1.jar:/home/ben/.m2/repository/com/thoughtworks/paranamer/paranamer/2.5.2/paranamer-2.5.2.jar:/home/ben/.m2/repository/com/facebook/swift/swift-service/0.13.1/swift-service-0.13.1.jar:/home/ben/.m2/repository/io/airlift/configuration/0.91/configuration-0.91.jar:/home/ben/.m2/repository/org/apache/bval/bval-jsr303/0.5/bval-jsr303-0.5.jar:/home/ben/.m2/repository/org/apache/bval/bval-core/0.5/bval-core-0.5.jar:/home/ben/.m2/repository/cglib/cglib-nodep/2.2.2/cglib-nodep-2.2.2.jar:/home/ben/.m2/repository/io/airlift/stats/0.91/stats-0.91.jar:/home/ben/.m2/repository/com/fasterxml/jackson/c
 ore/jackson-annotations/2.1.4/jackson-annotations-2.1.4.jar:/home/ben/.m2/repository/io/airlift/slice/0.5/slice-0.5.jar:/home/ben/.m2/repository/org/openjdk/jol/jol-core/0.1/jol-core-0.1.jar:/home/ben/.m2/repository/org/weakref/jmxutils/1.16/jmxutils-1.16.jar:/home/ben/.m2/repository/com/facebook/thirdparty/yourkit-api/yjp-controller-api-redist/11.0.10/yjp-controller-api-redist-11.0.10.jar:/home/ben/.m2/repository/com/google/code/findbugs/annotations/2.0.2/annotations-2.0.2.jar:/home/ben/.m2/repository/com/yammer/metrics/metrics-core/2.2.0/metrics-core-2.2.0.jar:/home/ben/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/ben/.m2/repository/io/netty/netty-all/4.0.14.Final/netty-all-4.0.14.Final.jar:/home/ben/.m2/repository/net/iharder/base64/2.3.8/base64-2.3.8.jar:/home/ben/.m2/repository/it/unimi/dsi/fastutil/6.5.4/fastutil-6.5.4.jar:/home/ben/.m2/repository/org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.jar:/home/ben/.m2/repository/org/jodah/typetools/0.2.1
 /typetools-0.2.1.jar:/home/ben/.m2/repository/org/json/json/20090211/json-20090211.jar:/home/ben/.m2/repository/org/python/jython/2.5.3/jython-2.5.3.jar:/home/ben/.m2/repository/javax/servlet/javax.servlet-api/3.0.1/javax.servlet-api-3.0.1.jar:/home/ben/incubator-tinkerpop/gremlin-test/target/gremlin-test-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/com/carrotsearch/junit-benchmarks/0.7.2/junit-benchmarks-0.7.2.jar:/home/ben/.m2/repository/com/h2database/h2/1.3.171/h2-1.3.171.jar:/home/ben/.m2/repository/junit/junit/4.12/junit-4.12.jar:/home/ben/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar:/home/ben/.m2/repository/org/mockito/mockito-all/1.9.5/mockito-all-1.9.5.jar:/home/ben/.m2/repository/org/hamcrest/hamcrest-all/1.3/hamcrest-all-1.3.jar:/home/ben/incubator-tinkerpop/hadoop-gremlin/target/hadoop-gremlin-3.1.1-SNAPSHOT-tests.jar:/home/ben/incubator-tinkerpop/gremlin-groovy-test/target/gremlin-groovy-test-3.1.1-SNAPSHOT.jar:/home/ben/incubator-tinkerpop/tinkerg
 raph-gremlin/target/tinkergraph-gremlin-3.1.1-SNAPSHOT.jar:, -Xmx512m, -XX:ParallelGCThreads=4, -XX:+UseConcMarkSweepGC, -XX:CMSInitiatingOccupancyFraction=70, -XX:MaxGCPauseMillis=100, org.apache.zookeeper.server.quorum.QuorumPeerMain, /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir/zoo.cfg] in directory /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Shutdown hook added.
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Connect attempt 0 of 10 max trying to connect to standalone-test:22181 with poll msecs = 3000
    [WARN] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Got ConnectException
    java.net.ConnectException: Connection refused
            at java.net.PlainSocketImpl.socketConnect(Native Method)
            at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
            at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
            at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
            at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
            at java.net.Socket.connect(Socket.java:589)
            at org.apache.giraph.zk.ZooKeeperManager.onlineZooKeeperServers(ZooKeeperManager.java:736)
            at org.apache.giraph.graph.GraphTaskManager.startZooKeeperManager(GraphTaskManager.java:421)
            at org.apache.giraph.graph.GraphTaskManager.setup(GraphTaskManager.java:219)
            at org.apache.giraph.graph.GraphMapper.setup(GraphMapper.java:61)
            at org.apache.giraph.graph.GraphMapper.run(GraphMapper.java:91)
            at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787)
            at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341)
            at org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:243)
            at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
            at java.util.concurrent.FutureTask.run(FutureTask.java:266)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
            at java.lang.Thread.run(Thread.java:745)
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Connect attempt 1 of 10 max trying to connect to standalone-test:22181 with poll msecs = 3000
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Connected to standalone-test/10.100.100.28:22181!
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Creating my filestamp _bsp/_defaultZkManagerDir/job_local387686867_0044/_zkServer/standalone-test 0
    [INFO] org.apache.giraph.graph.GraphTaskManager - setup: Chosen to run ZooKeeper...
    [INFO] org.apache.giraph.graph.GraphTaskManager - setup: Starting up BspServiceMaster (master thread)...
    [INFO] org.apache.giraph.bsp.BspService - BspService: Path to create to halt is /_hadoopBsp/job_local387686867_0044/_haltComputation
    [INFO] org.apache.giraph.bsp.BspService - BspService: Connecting to ZooKeeper with job job_local387686867_0044, 0 on standalone-test:22181
    [INFO] org.apache.zookeeper.ZooKeeper - Initiating client connection, connectString=standalone-test:22181 sessionTimeout=60000 watcher=org.apache.giraph.master.BspServiceMaster@89c9a29
    [INFO] org.apache.zookeeper.ClientCnxn$SendThread - Opening socket connection to server standalone-test/10.100.100.28:22181. Will not attempt to authenticate using SASL (unknown error)
    [INFO] org.apache.zookeeper.ClientCnxn$SendThread - Socket connection established to standalone-test/10.100.100.28:22181, initiating session
    [INFO] org.apache.zookeeper.ClientCnxn$SendThread - Session establishment complete on server standalone-test/10.100.100.28:22181, sessionid = 0x15232f438070000, negotiated timeout = 600000
    [INFO] org.apache.giraph.bsp.BspService - process: Asynchronous connection complete.
    [INFO] org.apache.giraph.graph.GraphTaskManager - setup: Starting up BspServiceWorker...
    [INFO] org.apache.giraph.bsp.BspService - BspService: Path to create to halt is /_hadoopBsp/job_local387686867_0044/_haltComputation
    [INFO] org.apache.giraph.bsp.BspService - BspService: Connecting to ZooKeeper with job job_local387686867_0044, 0 on standalone-test:22181
    [INFO] org.apache.zookeeper.ZooKeeper - Initiating client connection, connectString=standalone-test:22181 sessionTimeout=60000 watcher=org.apache.giraph.worker.BspServiceWorker@2ef7630c
    [INFO] org.apache.zookeeper.ClientCnxn$SendThread - Opening socket connection to server standalone-test/10.100.100.28:22181. Will not attempt to authenticate using SASL (unknown error)
    [INFO] org.apache.zookeeper.ClientCnxn$SendThread - Socket connection established to standalone-test/10.100.100.28:22181, initiating session
    [INFO] org.apache.zookeeper.ClientCnxn$SendThread - Session establishment complete on server standalone-test/10.100.100.28:22181, sessionid = 0x15232f438070001, negotiated timeout = 600000
    [INFO] org.apache.giraph.bsp.BspService - process: Asynchronous connection complete.
    [INFO] org.apache.giraph.comm.netty.NettyServer - start: Started server communication server: standalone-test/10.100.100.28:30000 with up to 16 threads on bind attempt 0 with sendBufferSize = 32768 receiveBufferSize = 524288
    [INFO] org.apache.giraph.graph.GraphTaskManager - setup: Registering health of this worker...
    [INFO] org.apache.giraph.bsp.BspService - getJobState: Job state already exists (/_hadoopBsp/job_local387686867_0044/_masterJobState)
    [INFO] org.apache.giraph.master.BspServiceMaster - becomeMaster: First child is '/_hadoopBsp/job_local387686867_0044/_masterElectionDir/standalone-test_00000000000' and my bid is '/_hadoopBsp/job_local387686867_0044/_masterElectionDir/standalone-test_00000000000'
    [INFO] org.apache.giraph.bsp.BspService - getApplicationAttempt: Node /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir already exists!
    [WARN] org.apache.giraph.comm.netty.NettyServer - start: Likely failed to bind on attempt 0 to port 30000
    [INFO] org.apache.giraph.bsp.BspService - process: applicationAttemptChanged signaled
    [INFO] org.apache.giraph.bsp.BspService - process: applicationAttemptChanged signaled
    [WARN] org.apache.giraph.bsp.BspService - process: Unknown and unprocessed event (path=/_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir, type=NodeChildrenChanged, state=SyncConnected)
    [INFO] org.apache.giraph.worker.BspServiceWorker - registerHealth: Created my health node for attempt=0, superstep=-1 with /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir/-1/_workerHealthyDir/standalone-test_0 and workerInfo= Worker(hostname=standalone-test, MRtaskID=0, port=30000)
    [INFO] org.apache.giraph.comm.netty.NettyServer - start: Started server communication server: standalone-test/10.100.100.28:30010 with up to 16 threads on bind attempt 1 with sendBufferSize = 32768 receiveBufferSize = 524288
    [INFO] org.apache.giraph.master.BspServiceMaster - becomeMaster: I am now the master!
    [INFO] org.apache.giraph.bsp.BspService - getApplicationAttempt: Node /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir already exists!
    [INFO] org.apache.giraph.master.BspServiceMaster - generateVertexInputSplits: Got 1 input splits for 2 input threads
    [WARN] org.apache.giraph.master.BspServiceMaster - createVertexInputSplits: Number of inputSplits=1 < 2=total number of input threads, some threads will be not used
    [INFO] org.apache.giraph.master.BspServiceMaster - createVertexInputSplits: Starting to write input split data to zookeeper with 1 threads
    [INFO] org.apache.giraph.master.BspServiceMaster - createVertexInputSplits: Done writing input split data to zookeeper
    [INFO] org.apache.giraph.comm.netty.NettyClient$1 - Using Netty without authentication.
    [INFO] org.apache.giraph.comm.netty.NettyClient - connectAllAddresses: Successfully added 1 connections, (1 total connected) 0 failed, 0 failures total.
    [INFO] org.apache.giraph.partition.PartitionUtils - computePartitionCount: Creating 1, default would have been 1 partitions.
    [INFO] org.apache.giraph.bsp.BspService - process: partitionAssignmentsReadyChanged (partitions are assigned)
    [INFO] org.apache.giraph.worker.BspServiceWorker - startSuperstep: Master(hostname=standalone-test, MRtaskID=0, port=30010)
    [INFO] org.apache.giraph.worker.BspServiceWorker - startSuperstep: Ready for computation on superstep -1 since worker selection and vertex range assignments are done in /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir/-1/_addressesAndPartitions
    [INFO] org.apache.giraph.master.BspServiceMaster - barrierOnWorkerList: 0 out of 1 workers finished on superstep -1 on path /_hadoopBsp/job_local387686867_0044/_vertexInputSplitDoneDir
    [INFO] org.apache.giraph.master.BspServiceMaster - barrierOnWorkerList: Waiting on [standalone-test_0]
    [INFO] org.apache.giraph.comm.netty.NettyServer$1 - start: Using Netty without authentication.
    [INFO] org.apache.giraph.comm.netty.handler.RequestDecoder - decode: Server window metrics MBytes/sec received = 0, MBytesReceived = 0.0001, ave received req MBytes = 0.0001, secs waited = 1.45255386E9
    [INFO] org.apache.giraph.comm.netty.NettyClient$1 - Using Netty without authentication.
    [INFO] org.apache.giraph.comm.netty.NettyClient - connectAllAddresses: Successfully added 1 connections, (1 total connected) 0 failed, 0 failures total.
    [INFO] org.apache.giraph.comm.netty.NettyServer$1 - start: Using Netty without authentication.
    [INFO] org.apache.giraph.worker.BspServiceWorker - loadInputSplits: Using 1 thread(s), originally 2 threads(s) for 1 total splits.
    [INFO] org.apache.giraph.worker.InputSplitsHandler - reserveInputSplit: Reserved input split path /_hadoopBsp/job_local387686867_0044/_vertexInputSplitDir/0, overall roughly 0.0% input splits reserved
    [INFO] org.apache.giraph.worker.InputSplitsCallable - getInputSplit: Reserved /_hadoopBsp/job_local387686867_0044/_vertexInputSplitDir/0 from ZooKeeper and got input split 'file:/home/ben/incubator-tinkerpop/giraph-gremlin/target/test-case-data/GraphSONResourceAccess/resources/tinkerpop-modern.json:0+1333'
    [INFO] org.apache.giraph.worker.InputSplitsCallable - loadFromInputSplit: Finished loading /_hadoopBsp/job_local387686867_0044/_vertexInputSplitDir/0 (v=6, e=0)
    [INFO] org.apache.giraph.worker.InputSplitsCallable - call: Loaded 1 input splits in 0.013278969 secs, (v=6, e=0) 451.84232 vertices/sec, 0.0 edges/sec
    [INFO] org.apache.giraph.comm.netty.NettyClient - waitAllRequests: Finished all requests. MBytes/sec received = 0, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 1.45255386E9
    MBytes/sec sent = 0, MBytesSent = 0, ave sent req MBytes = 0, secs waited = 1.45255386E9
    [INFO] org.apache.giraph.worker.BspServiceWorker - setup: Finally loaded a total of (v=6, e=0)
    [INFO] org.apache.giraph.bsp.BspService - process: vertexInputSplitsAllDoneChanged (all vertices sent from input splits)
    [INFO] org.apache.giraph.worker.BspServiceWorker - finishSuperstep: Waiting on all requests, superstep -1 Memory (free/total/max) = 319.28M / 723.00M / 1776.00M
    [INFO] org.apache.giraph.comm.netty.NettyClient - waitAllRequests: Finished all requests. MBytes/sec received = 0, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 1.45255386E9
    MBytes/sec sent = 0, MBytesSent = 0, ave sent req MBytes = 0, secs waited = 1.45255386E9
    [INFO] org.apache.giraph.worker.WorkerAggregatorHandler - finishSuperstep: Start gathering aggregators, workers will send their aggregated values once they are done with superstep computation
    [INFO] org.apache.giraph.comm.netty.handler.RequestDecoder - decode: Server window metrics MBytes/sec received = 0, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 1.45255386E9
    [INFO] org.apache.giraph.master.BspServiceMaster - barrierOnWorkerList: 0 out of 1 workers finished on superstep -1 on path /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir/-1/_workerFinishedDir
    [INFO] org.apache.giraph.master.BspServiceMaster - barrierOnWorkerList: Waiting on [standalone-test_0]
    [INFO] org.apache.giraph.comm.netty.NettyClient - waitAllRequests: Finished all requests. MBytes/sec received = 0.0062, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 0.001
    MBytes/sec sent = 0.0119, MBytesSent = 0, ave sent req MBytes = 0, secs waited = 0.001
    [INFO] org.apache.giraph.worker.BspServiceWorker - finishSuperstep: Superstep -1, messages = 0 , message bytes = 0 , Memory (free/total/max) = 318.00M / 723.00M / 1776.00M
    [INFO] org.apache.giraph.utils.LoggerUtils - finishSuperstep: (waiting for rest of workers) ALL - Attempt=0, Superstep=-1
    [INFO] org.apache.giraph.master.BspServiceMaster - aggregateWorkerStats: Aggregation found (vtx=6,finVtx=0,edges=0,msgCount=0,msgBytesCount=0,haltComputation=false, checkpointStatus=NONE) on superstep = -1
    [INFO] org.apache.giraph.bsp.BspService - process: superstepFinished signaled
    [INFO] org.apache.giraph.worker.BspServiceWorker - finishSuperstep: Completed superstep -1 with global stats (vtx=6,finVtx=0,edges=0,msgCount=0,msgBytesCount=0,haltComputation=false, checkpointStatus=NONE) and classes (computation=org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphComputation,combiner=org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphMessageCombiner,incoming=null,outgoing=null)
    [INFO] org.apache.giraph.master.MasterThread - masterThread: Coordination of superstep -1 took 0.077 seconds ended with state THIS_SUPERSTEP_DONE and is now on superstep 0
    [WARN] org.apache.giraph.bsp.BspService - process: Unknown and unprocessed event (path=/_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir, type=NodeChildrenChanged, state=SyncConnected)
    [INFO] org.apache.giraph.comm.messages.InMemoryMessageStoreFactory - newStore: Created class org.apache.giraph.comm.messages.OneMessagePerVertexStore for vertex id class org.apache.tinkerpop.gremlin.hadoop.structure.io.ObjectWritable and message value class org.apache.tinkerpop.gremlin.hadoop.structure.io.ObjectWritable and message combiner class org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphMessageCombiner
    [INFO] org.apache.giraph.comm.messages.InMemoryMessageStoreFactory - newStore: Created class org.apache.giraph.comm.messages.OneMessagePerVertexStore for vertex id class org.apache.tinkerpop.gremlin.hadoop.structure.io.ObjectWritable and message value class org.apache.tinkerpop.gremlin.hadoop.structure.io.ObjectWritable and message combiner class org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphMessageCombiner
    [INFO] org.apache.giraph.comm.netty.NettyClient - connectAllAddresses: Successfully added 0 connections, (0 total connected) 0 failed, 0 failures total.
    [INFO] org.apache.giraph.partition.PartitionBalancer - balancePartitionsAcrossWorkers: Using algorithm static
    [INFO] org.apache.giraph.partition.PartitionUtils - analyzePartitionStats: [Worker(hostname=standalone-test, MRtaskID=0, port=30000):(v=6, e=0),]
    [INFO] org.apache.giraph.partition.PartitionUtils - analyzePartitionStats: Vertices - Mean: 6, Min: Worker(hostname=standalone-test, MRtaskID=0, port=30000) - 6, Max: Worker(hostname=standalone-test, MRtaskID=0, port=30000) - 6
    [INFO] org.apache.giraph.partition.PartitionUtils - analyzePartitionStats: Edges - Mean: 0, Min: Worker(hostname=standalone-test, MRtaskID=0, port=30000) - 0, Max: Worker(hostname=standalone-test, MRtaskID=0, port=30000) - 0
    [INFO] org.apache.giraph.worker.BspServiceWorker - registerHealth: Created my health node for attempt=0, superstep=0 with /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir/0/_workerHealthyDir/standalone-test_0 and workerInfo= Worker(hostname=standalone-test, MRtaskID=0, port=30000)
    [INFO] org.apache.giraph.worker.BspServiceWorker - startSuperstep: Master(hostname=standalone-test, MRtaskID=0, port=30010)
    [INFO] org.apache.giraph.worker.BspServiceWorker - startSuperstep: Ready for computation on superstep 0 since worker selection and vertex range assignments are done in /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir/0/_addressesAndPartitions
    [INFO] org.apache.giraph.comm.netty.NettyClient - connectAllAddresses: Successfully added 0 connections, (0 total connected) 0 failed, 0 failures total.
    [INFO] org.apache.giraph.comm.netty.NettyClient - waitAllRequests: Finished all requests. MBytes/sec received = 0.0002, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 0.055
    MBytes/sec sent = 0.0004, MBytesSent = 0, ave sent req MBytes = 0, secs waited = 0.055
    [INFO] org.apache.giraph.worker.BspServiceWorker - sendWorkerPartitions: Done sending all my partitions.
    [INFO] org.apache.giraph.worker.BspServiceWorker - exchangeVertexPartitions: Done with exchange.
    [INFO] org.apache.giraph.graph.GraphTaskManager - execute: 1 partitions to process with 1 compute thread(s), originally 2 thread(s) on superstep 0
    [INFO] org.apache.giraph.graph.ComputeCallable - call: Computation took 0.012862378 secs for 1 partitions on superstep 0.  Flushing started
    [INFO] org.apache.giraph.worker.BspServiceWorker - finishSuperstep: Waiting on all requests, superstep 0 Memory (free/total/max) = 309.15M / 723.00M / 1776.00M
    [INFO] org.apache.giraph.comm.netty.NettyClient - waitAllRequests: Finished all requests. MBytes/sec received = 0.0002, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 0.071
    MBytes/sec sent = 0.0003, MBytesSent = 0, ave sent req MBytes = 0, secs waited = 0.071
    [INFO] org.apache.giraph.worker.WorkerAggregatorHandler - finishSuperstep: Start gathering aggregators, workers will send their aggregated values once they are done with superstep computation
    [INFO] org.apache.giraph.comm.netty.NettyClient - waitAllRequests: Finished all requests. MBytes/sec received = 0.0062, MBytesReceived = 0, ave received req MBytes = 0, secs waited = 0.001
    MBytes/sec sent = 0.0563, MBytesSent = 0.0001, ave sent req MBytes = 0.0001, secs waited = 0.001
    [INFO] org.apache.giraph.worker.BspServiceWorker - finishSuperstep: Superstep 0, messages = 0 , message bytes = 0 , Memory (free/total/max) = 309.15M / 723.00M / 1776.00M
    [INFO] org.apache.giraph.master.BspServiceMaster - barrierOnWorkerList: 1 out of 1 workers finished on superstep 0 on path /_hadoopBsp/job_local387686867_0044/_applicationAttemptsDir/0/_superstepDir/0/_workerFinishedDir
    [INFO] org.apache.giraph.master.BspServiceMaster - barrierOnWorkerList: Waiting on []
    [INFO] org.apache.giraph.utils.LoggerUtils - finishSuperstep: (waiting for rest of workers) ALL - Attempt=0, Superstep=0
    [INFO] org.apache.giraph.master.BspServiceMaster - aggregateWorkerStats: Aggregation found (vtx=6,finVtx=0,edges=0,msgCount=0,msgBytesCount=0,haltComputation=false, checkpointStatus=NONE) on superstep = 0
    [INFO] org.apache.giraph.bsp.BspService - process: superstepFinished signaled
    [INFO] org.apache.giraph.master.MasterThread - masterThread: Coordination of superstep 0 took 0.095 seconds ended with state ALL_SUPERSTEPS_DONE and is now on superstep 1
    [INFO] org.apache.giraph.master.BspServiceMaster - setJobState: {"_applicationAttemptKey":-1,"_stateKey":"FINISHED","_superstepKey":-1} on superstep 1
    [INFO] org.apache.giraph.worker.BspServiceWorker - processEvent: Job state changed, checking to see if it needs to restart
    [INFO] org.apache.giraph.master.BspServiceMaster - setJobState: {"_applicationAttemptKey":-1,"_stateKey":"FINISHED","_superstepKey":-1}
    [INFO] org.apache.giraph.worker.BspServiceWorker - finishSuperstep: Completed superstep 0 with global stats (vtx=6,finVtx=0,edges=0,msgCount=0,msgBytesCount=0,haltComputation=true, checkpointStatus=NONE) and classes (computation=org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphComputation,combiner=org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphMessageCombiner,incoming=null,outgoing=null)
    [INFO] org.apache.giraph.graph.GraphTaskManager - execute: BSP application done (global vertices marked done)
    [INFO] org.apache.giraph.graph.GraphTaskManager - cleanup: Starting for ALL
    [INFO] org.apache.giraph.comm.netty.NettyClient - stop: Halting netty client
    [INFO] org.apache.giraph.comm.netty.NettyClient$2 - stop: reached wait threshold, 1 connections closed, releasing resources now.
    [INFO] org.apache.giraph.bsp.BspService - getJobState: Job state already exists (/_hadoopBsp/job_local387686867_0044/_masterJobState)
    [INFO] org.apache.giraph.master.BspServiceMaster - cleanup: Notifying master its okay to cleanup with /_hadoopBsp/job_local387686867_0044/_cleanedUpDir/0_master
    [INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Node /_hadoopBsp/job_local387686867_0044/_cleanedUpDir already exists, no need to create.
    [INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Got 1 of 2 desired children from /_hadoopBsp/job_local387686867_0044/_cleanedUpDir
    [INFO] org.apache.giraph.master.BspServiceMaster - cleanedUpZooKeeper: Waiting for the children of /_hadoopBsp/job_local387686867_0044/_cleanedUpDir to change since only got 1 nodes.
    [INFO] org.apache.giraph.comm.netty.NettyClient - stop: Netty client halted
    [INFO] org.apache.giraph.utils.LoggerUtils - saveVertices: Starting to save 6 vertices using 1 threads
    [INFO] org.apache.giraph.utils.LoggerUtils - saveVertices: Done saving vertices.
    [WARN] org.apache.giraph.worker.BspServiceWorker - saveEdges:   giraph.edgeOutputFormatClass => null [EdgeOutputFormat]  (class)
    Make sure that the EdgeOutputFormat is not required.
    [INFO] org.apache.giraph.bsp.BspService - process: cleanedUpChildrenChanged signaled
    [INFO] org.apache.giraph.worker.BspServiceWorker - cleanup: Notifying master its okay to cleanup with /_hadoopBsp/job_local387686867_0044/_cleanedUpDir/0_worker
    [INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Got 2 of 2 desired children from /_hadoopBsp/job_local387686867_0044/_cleanedUpDir
    [INFO] org.apache.giraph.master.BspServiceMaster - cleanup: Removed HDFS checkpoint directory (_bsp/_checkpoints//job_local387686867_0044) with return = false since the job HadoopGremlin(Giraph): TraversalVertexProgram[GraphStep([],vertex), BranchStep([LabelStep, IsStep(eq(person)), CountGlobalStep],{0=[[PropertiesStep([lang],value), EndStep], [PropertiesStep([name],value), EndStep]], 1=[[PropertiesStep([age],value), EndStep]]}), ComputerResultStep] succeeded 
    [INFO] org.apache.giraph.comm.netty.NettyClient - stop: Halting netty client
    [INFO] org.apache.giraph.comm.netty.NettyClient$2 - stop: reached wait threshold, 1 connections closed, releasing resources now.
    [INFO] org.apache.zookeeper.ZooKeeper - Session: 0x15232f438070001 closed
    [INFO] org.apache.giraph.comm.netty.NettyServer - stop: Halting netty server
    [INFO] org.apache.zookeeper.ClientCnxn$EventThread - EventThread shut down
    [INFO] org.apache.giraph.comm.netty.NettyServer - stop: Start releasing resources
    [INFO] org.apache.giraph.job.HaltApplicationUtils$DefaultHaltInstructionsWriter - writeHaltInstructions: To halt after next superstep execute: 'bin/halt-application --zkServer standalone-test:22181 --zkNode /_hadoopBsp/job_local387686867_0044/_haltComputation'
    [INFO] org.apache.giraph.comm.netty.NettyClient - stop: Netty client halted
    [INFO] org.apache.giraph.comm.netty.NettyServer - stop: Halting netty server
    [INFO] org.apache.giraph.comm.netty.NettyServer - stop: Start releasing resources
    [INFO] org.apache.giraph.comm.netty.NettyServer - stop: Netty server halted
    [INFO] org.apache.giraph.comm.netty.NettyServer - stop: Netty server halted
    [INFO] org.apache.giraph.bsp.BspService - process: masterElectionChildrenChanged signaled
    [INFO] org.apache.zookeeper.ZooKeeper - Session: 0x15232f438070000 closed
    [INFO] org.apache.giraph.master.MasterThread - setup: Took 0.013 seconds.
    [INFO] org.apache.giraph.master.MasterThread - input superstep: Took 0.077 seconds.
    [INFO] org.apache.giraph.master.MasterThread - superstep 0: Took 0.095 seconds.
    [INFO] org.apache.zookeeper.ClientCnxn$EventThread - EventThread shut down
    [INFO] org.apache.giraph.master.MasterThread - shutdown: Took 6.636 seconds.
    [INFO] org.apache.giraph.master.MasterThread - total: Took 6.825 seconds.
    [INFO] org.apache.giraph.graph.GraphTaskManager - cleanup: Joined with master thread
    [INFO] org.apache.giraph.graph.GraphTaskManager - cleanup: Offlining ZooKeeper servers
    [INFO] org.apache.giraph.zk.ZooKeeperManager - createZooKeeperClosedStamp: Creating my filestamp _bsp/_defaultZkManagerDir/job_local387686867_0044/_task/0.COMPUTATION_DONE
    [INFO] org.apache.giraph.zk.ZooKeeperManager - offlineZooKeeperServers: Will wait for 1 tasks
    [INFO] org.apache.giraph.zk.ZooKeeperManager - waitUntilAllTasksDone: Got 1 and 1 desired (polling period is 3000) on attempt 0
    [INFO] org.apache.giraph.zk.ZooKeeperManager - offlineZooKeeperServers: waitFor returned 143 and deleted directory /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir
    [INFO] org.apache.tinkerpop.gremlin.hadoop.process.computer.util.MapReduceHelper - HadoopGremlin: TraverserMapReduce[~traversers]
    [INFO] org.apache.tinkerpop.gremlin.AbstractGremlinTest -   post-strategy:[GraphStep([],vertex), BranchStep([LabelStep, IsStep(eq(person)), CountGlobalStep],{0=[[PropertiesStep([lang],value), EndStep], [PropertiesStep([name],value), EndStep]], 1=[[PropertiesStep([age],value), EndStep]]}), ComputerResultStep]
    [INFO] org.apache.tinkerpop.gremlin.AbstractGremlinTest - Testing: g_V_chooseXout_countX_optionX2L__nameX_optionX3L__valueMapX
    [INFO] org.apache.tinkerpop.gremlin.AbstractGremlinTest -    pre-strategy:[GraphStep([],vertex), ChooseStep([VertexStep(OUT,vertex), CountGlobalStep],{2=[[PropertiesStep([name],value), EndStep]], 3=[[PropertyMapStep(value), EndStep]]})]
    [INFO] org.apache.tinkerpop.gremlin.giraph.process.computer.GiraphGraphComputer - HadoopGremlin(Giraph): TraversalVertexProgram[GraphStep([],vertex), ChooseStep([VertexStep(OUT,edge), CountGlobalStep],{2=[[PropertiesStep([name],value), EndStep]], 3=[[PropertyMapStep(value), EndStep]]}), ComputerResultStep]
    [INFO] org.apache.giraph.job.GiraphJob - run: Since checkpointing is disabled (default), do not allow any task retries (setting mapred.map.max.attempts = 0, old value = 4)
    [INFO] org.apache.giraph.job.GiraphJob - Tracking URL: http://localhost:8080/
    [INFO] org.apache.giraph.job.GiraphJob - Waiting for resources... Job will start only when it gets all 2 mappers
    [INFO] org.apache.giraph.graph.GraphTaskManager - setup: Log level remains at info
    [INFO] org.apache.giraph.zk.ZooKeeperManager - createCandidateStamp: Made the directory _bsp/_defaultZkManagerDir/job_local928423104_0046
    [INFO] org.apache.giraph.zk.ZooKeeperManager - createCandidateStamp: Made the directory _bsp/_defaultZkManagerDir/job_local928423104_0046/_zkServer
    [INFO] org.apache.giraph.zk.ZooKeeperManager - createCandidateStamp: Creating my filestamp _bsp/_defaultZkManagerDir/job_local928423104_0046/_task/standalone-test 0
    [INFO] org.apache.giraph.zk.ZooKeeperManager - getZooKeeperServerList: Got [standalone-test] 1 hosts from 1 candidates when 1 required (polling period is 3000) on attempt 0
    [INFO] org.apache.giraph.zk.ZooKeeperManager - createZooKeeperServerList: Creating the final ZooKeeper file '_bsp/_defaultZkManagerDir/job_local928423104_0046/zkServerList_standalone-test 0 '
    [INFO] org.apache.giraph.zk.ZooKeeperManager - getZooKeeperServerList: For task 0, got file 'zkServerList_standalone-test 0 ' (polling period is 3000)
    [INFO] org.apache.giraph.zk.ZooKeeperManager - getZooKeeperServerList: Found [standalone-test, 0] 2 hosts in filename 'zkServerList_standalone-test 0 '
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Trying to delete old directory /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir
    [INFO] org.apache.giraph.zk.ZooKeeperManager - generateZooKeeperConfigFile: Creating file /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir/zoo.cfg in /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir with base port 22181
    [INFO] org.apache.giraph.zk.ZooKeeperManager - generateZooKeeperConfigFile: Make directory of _defaultZkManagerDir = true
    [INFO] org.apache.giraph.zk.ZooKeeperManager - generateZooKeeperConfigFile: Delete of zoo.cfg = false
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Attempting to start ZooKeeper server with command [/usr/lib/jvm/sift-jdk1.8.0_66/jre/bin/java, -cp, /home/ben/incubator-tinkerpop/giraph-gremlin/target/test-classes:/home/ben/incubator-tinkerpop/giraph-gremlin/target/classes:/home/ben/incubator-tinkerpop/gremlin-core/target/gremlin-core-3.1.1-SNAPSHOT.jar:/home/ben/incubator-tinkerpop/gremlin-shaded/target/gremlin-shaded-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/commons-configuration/commons-configuration/1.10/commons-configuration-1.10.jar:/home/ben/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/ben/.m2/repository/org/yaml/snakeyaml/1.15/snakeyaml-1.15.jar:/home/ben/.m2/repository/org/javatuples/javatuples/1.2/javatuples-1.2.jar:/home/ben/.m2/repository/com/carrotsearch/hppc/0.7.1/hppc-0.7.1.jar:/home/ben/.m2/repository/com/jcabi/jcabi-manifests/1.1/jcabi-manifests-1.1.jar:/home/ben/.m2/repository/com/jcabi/jcabi-log/0.14/jcabi-log-
 0.14.jar:/home/ben/.m2/repository/org/slf4j/slf4j-log4j12/1.7.12/slf4j-log4j12-1.7.12.jar:/home/ben/.m2/repository/org/slf4j/slf4j-api/1.7.12/slf4j-api-1.7.12.jar:/home/ben/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/ben/.m2/repository/org/slf4j/jcl-over-slf4j/1.7.12/jcl-over-slf4j-1.7.12.jar:/home/ben/incubator-tinkerpop/gremlin-groovy/target/gremlin-groovy-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/org/apache/ivy/ivy/2.3.0/ivy-2.3.0.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy/2.4.5/groovy-2.4.5-indy.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-groovysh/2.4.5/groovy-groovysh-2.4.5-indy.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-console/2.4.5/groovy-console-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-templates/2.4.5/groovy-templates-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-xml/2.4.5/groovy-xml-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-swing/2.4.5/groovy-swing-2.4.5.jar:/home/
 ben/.m2/repository/jline/jline/2.12/jline-2.12.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy/2.4.5/groovy-2.4.5.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-json/2.4.5/groovy-json-2.4.5-indy.jar:/home/ben/.m2/repository/org/codehaus/groovy/groovy-jsr223/2.4.5/groovy-jsr223-2.4.5-indy.jar:/home/ben/.m2/repository/org/apache/commons/commons-lang3/3.3.1/commons-lang3-3.3.1.jar:/home/ben/.m2/repository/org/mindrot/jbcrypt/0.3m/jbcrypt-0.3m.jar:/home/ben/incubator-tinkerpop/hadoop-gremlin/target/hadoop-gremlin-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-client/2.7.1/hadoop-client-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-common/2.7.1/hadoop-common-2.7.1.jar:/home/ben/.m2/repository/org/apache/commons/commons-math3/3.1.1/commons-math3-3.1.1.jar:/home/ben/.m2/repository/xmlenc/xmlenc/0.52/xmlenc-0.52.jar:/home/ben/.m2/repository/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar:/home/ben/.m2/repository/commo
 ns-io/commons-io/2.4/commons-io-2.4.jar:/home/ben/.m2/repository/commons-net/commons-net/3.1/commons-net-3.1.jar:/home/ben/.m2/repository/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar:/home/ben/.m2/repository/javax/servlet/jsp/jsp-api/2.1/jsp-api-2.1.jar:/home/ben/.m2/repository/org/apache/avro/avro/1.7.4/avro-1.7.4.jar:/home/ben/.m2/repository/com/google/protobuf/protobuf-java/2.5.0/protobuf-java-2.5.0.jar:/home/ben/.m2/repository/com/google/code/gson/gson/2.2.4/gson-2.2.4.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-auth/2.7.1/hadoop-auth-2.7.1.jar:/home/ben/.m2/repository/org/apache/httpcomponents/httpclient/4.2.5/httpclient-4.2.5.jar:/home/ben/.m2/repository/org/apache/httpcomponents/httpcore/4.2.4/httpcore-4.2.4.jar:/home/ben/.m2/repository/org/apache/directory/server/apacheds-kerberos-codec/2.0.0-M15/apacheds-kerberos-codec-2.0.0-M15.jar:/home/ben/.m2/repository/org/apache/directory/server/apacheds-i18n/2.0.0-M15/apacheds-i18n-2.0.0-M15.j
 ar:/home/ben/.m2/repository/org/apache/directory/api/api-asn1-api/1.0.0-M20/api-asn1-api-1.0.0-M20.jar:/home/ben/.m2/repository/org/apache/directory/api/api-util/1.0.0-M20/api-util-1.0.0-M20.jar:/home/ben/.m2/repository/org/apache/curator/curator-framework/2.7.1/curator-framework-2.7.1.jar:/home/ben/.m2/repository/org/apache/curator/curator-client/2.7.1/curator-client-2.7.1.jar:/home/ben/.m2/repository/org/apache/curator/curator-recipes/2.7.1/curator-recipes-2.7.1.jar:/home/ben/.m2/repository/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.jar:/home/ben/.m2/repository/org/apache/htrace/htrace-core/3.1.0-incubating/htrace-core-3.1.0-incubating.jar:/home/ben/.m2/repository/org/apache/commons/commons-compress/1.4.1/commons-compress-1.4.1.jar:/home/ben/.m2/repository/org/tukaani/xz/1.0/xz-1.0.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-hdfs/2.7.1/hadoop-hdfs-2.7.1.jar:/home/ben/.m2/repository/org/mortbay/jetty/jetty-util/6.1.26/jetty-util-6.1.26.jar:/home/ben/.m2/repository
 /xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar:/home/ben/.m2/repository/xml-apis/xml-apis/1.3.04/xml-apis-1.3.04.jar:/home/ben/.m2/repository/org/fusesource/leveldbjni/leveldbjni-all/1.8/leveldbjni-all-1.8.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-app/2.7.1/hadoop-mapreduce-client-app-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-common/2.7.1/hadoop-mapreduce-client-common-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-yarn-client/2.7.1/hadoop-yarn-client-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-yarn-server-common/2.7.1/hadoop-yarn-server-common-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-shuffle/2.7.1/hadoop-mapreduce-client-shuffle-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-yarn-api/2.7.1/hadoop-yarn-api-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-core/2.7.1/hadoop-mapreduce-client-core-2.7.1.jar:/home/ben/.m2
 /repository/org/apache/hadoop/hadoop-yarn-common/2.7.1/hadoop-yarn-common-2.7.1.jar:/home/ben/.m2/repository/javax/xml/bind/jaxb-api/2.2.2/jaxb-api-2.2.2.jar:/home/ben/.m2/repository/javax/xml/stream/stax-api/1.0-2/stax-api-1.0-2.jar:/home/ben/.m2/repository/javax/activation/activation/1.1/activation-1.1.jar:/home/ben/.m2/repository/com/sun/jersey/jersey-core/1.9/jersey-core-1.9.jar:/home/ben/.m2/repository/com/sun/jersey/jersey-client/1.9/jersey-client-1.9.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-jaxrs/1.9.13/jackson-jaxrs-1.9.13.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-xc/1.9.13/jackson-xc-1.9.13.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-jobclient/2.7.1/hadoop-mapreduce-client-jobclient-2.7.1.jar:/home/ben/.m2/repository/org/apache/hadoop/hadoop-annotations/2.7.1/hadoop-annotations-2.7.1.jar:/home/ben/.m2/repository/commons-codec/commons-codec/1.6/commons-codec-1.6.jar:/home/ben/.m2/repository/commons-logging/commons-l
 ogging/1.1.3/commons-logging-1.1.3.jar:/home/ben/.m2/repository/com/google/guava/guava/16.0.1/guava-16.0.1.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-mapper-asl/1.9.13/jackson-mapper-asl-1.9.13.jar:/home/ben/.m2/repository/org/codehaus/jackson/jackson-core-asl/1.9.13/jackson-core-asl-1.9.13.jar:/home/ben/.m2/repository/org/xerial/snappy/snappy-java/1.1.1.7/snappy-java-1.1.1.7.jar:/home/ben/.m2/repository/org/apache/giraph/giraph-core/1.1.0-hadoop2/giraph-core-1.1.0-hadoop2.jar:/home/ben/.m2/repository/com/facebook/nifty/nifty-client/0.13.1/nifty-client-0.13.1.jar:/home/ben/.m2/repository/com/facebook/nifty/nifty-core/0.13.1/nifty-core-0.13.1.jar:/home/ben/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar:/home/ben/.m2/repository/com/google/inject/extensions/guice-multibindings/3.0/guice-multibindings-3.0.jar:/home/ben/.m2/repository/com/google/inject/guice/3.0/guice-3.0.jar:/home/ben/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar:/home/ben/
 .m2/repository/io/airlift/units/0.91/units-0.91.jar:/home/ben/.m2/repository/javax/validation/validation-api/1.1.0.Final/validation-api-1.1.0.Final.jar:/home/ben/.m2/repository/io/netty/netty/3.7.0.Final/netty-3.7.0.Final.jar:/home/ben/.m2/repository/com/facebook/swift/swift-annotations/0.13.1/swift-annotations-0.13.1.jar:/home/ben/.m2/repository/com/facebook/swift/swift-codec/0.13.1/swift-codec-0.13.1.jar:/home/ben/.m2/repository/com/thoughtworks/paranamer/paranamer/2.5.2/paranamer-2.5.2.jar:/home/ben/.m2/repository/com/facebook/swift/swift-service/0.13.1/swift-service-0.13.1.jar:/home/ben/.m2/repository/io/airlift/configuration/0.91/configuration-0.91.jar:/home/ben/.m2/repository/org/apache/bval/bval-jsr303/0.5/bval-jsr303-0.5.jar:/home/ben/.m2/repository/org/apache/bval/bval-core/0.5/bval-core-0.5.jar:/home/ben/.m2/repository/cglib/cglib-nodep/2.2.2/cglib-nodep-2.2.2.jar:/home/ben/.m2/repository/io/airlift/stats/0.91/stats-0.91.jar:/home/ben/.m2/repository/com/fasterxml/jackson/c
 ore/jackson-annotations/2.1.4/jackson-annotations-2.1.4.jar:/home/ben/.m2/repository/io/airlift/slice/0.5/slice-0.5.jar:/home/ben/.m2/repository/org/openjdk/jol/jol-core/0.1/jol-core-0.1.jar:/home/ben/.m2/repository/org/weakref/jmxutils/1.16/jmxutils-1.16.jar:/home/ben/.m2/repository/com/facebook/thirdparty/yourkit-api/yjp-controller-api-redist/11.0.10/yjp-controller-api-redist-11.0.10.jar:/home/ben/.m2/repository/com/google/code/findbugs/annotations/2.0.2/annotations-2.0.2.jar:/home/ben/.m2/repository/com/yammer/metrics/metrics-core/2.2.0/metrics-core-2.2.0.jar:/home/ben/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/ben/.m2/repository/io/netty/netty-all/4.0.14.Final/netty-all-4.0.14.Final.jar:/home/ben/.m2/repository/net/iharder/base64/2.3.8/base64-2.3.8.jar:/home/ben/.m2/repository/it/unimi/dsi/fastutil/6.5.4/fastutil-6.5.4.jar:/home/ben/.m2/repository/org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.jar:/home/ben/.m2/repository/org/jodah/typetools/0.2.1
 /typetools-0.2.1.jar:/home/ben/.m2/repository/org/json/json/20090211/json-20090211.jar:/home/ben/.m2/repository/org/python/jython/2.5.3/jython-2.5.3.jar:/home/ben/.m2/repository/javax/servlet/javax.servlet-api/3.0.1/javax.servlet-api-3.0.1.jar:/home/ben/incubator-tinkerpop/gremlin-test/target/gremlin-test-3.1.1-SNAPSHOT.jar:/home/ben/.m2/repository/com/carrotsearch/junit-benchmarks/0.7.2/junit-benchmarks-0.7.2.jar:/home/ben/.m2/repository/com/h2database/h2/1.3.171/h2-1.3.171.jar:/home/ben/.m2/repository/junit/junit/4.12/junit-4.12.jar:/home/ben/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar:/home/ben/.m2/repository/org/mockito/mockito-all/1.9.5/mockito-all-1.9.5.jar:/home/ben/.m2/repository/org/hamcrest/hamcrest-all/1.3/hamcrest-all-1.3.jar:/home/ben/incubator-tinkerpop/hadoop-gremlin/target/hadoop-gremlin-3.1.1-SNAPSHOT-tests.jar:/home/ben/incubator-tinkerpop/gremlin-groovy-test/target/gremlin-groovy-test-3.1.1-SNAPSHOT.jar:/home/ben/incubator-tinkerpop/tinkerg
 raph-gremlin/target/tinkergraph-gremlin-3.1.1-SNAPSHOT.jar:, -Xmx512m, -XX:ParallelGCThreads=4, -XX:+UseConcMarkSweepGC, -XX:CMSInitiatingOccupancyFraction=70, -XX:MaxGCPauseMillis=100, org.apache.zookeeper.server.quorum.QuorumPeerMain, /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir/zoo.cfg] in directory /home/ben/incubator-tinkerpop/giraph-gremlin/_bsp/_defaultZkManagerDir
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Shutdown hook added.
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Connect attempt 0 of 10 max trying to connect to standalone-test:22181 with poll msecs = 3000
    [WARN] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Got ConnectException
    java.net.ConnectException: Connection refused
            at java.net.PlainSocketImpl.socketConnect(Native Method)
            at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
            at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
            at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
            at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
            at java.net.Socket.connect(Socket.java:589)
            at org.apache.giraph.zk.ZooKeeperManager.onlineZooKeeperServers(ZooKeeperManager.java:736)
            at org.apache.giraph.graph.GraphTaskManager.startZooKeeperManager(GraphTaskManager.java:421)
            at org.apache.giraph.graph.GraphTaskManager.setup(GraphTaskManager.java:219)
            at org.apache.giraph.graph.GraphMapper.setup(GraphMapper.java:61)
            at org.apache.giraph.graph.GraphMapper.run(GraphMapper.java:91)
            at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787)
            at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341)
            at org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:243)
            at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
            at java.util.concurrent.FutureTask.run(FutureTask.java:266)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
            at java.lang.Thread.run(Thread.java:745)
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Connect attempt 1 of 10 max trying to connect to standalone-test:22181 with poll msecs = 3000
    [INFO] org.apache.giraph.zk.ZooKeeperManager - onlineZooKeeperServers: Connected to standalone-test/10.100.100.28:22181!
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-171029571
  
    Changes were same as i had last night when all worked for me:  VOTE +1 (binding)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170703538
  
    There is a bug in the docs. You no longer need ZooKeeper running. Thus, just do `mvn clean install -DskipIntegrationTests=false -DincludeNeo4j` from the root directory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by laxatives <gi...@git.apache.org>.
Github user laxatives commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170699026
  
    Are there instructions for executing the integration test? I am getting a connection refused to standalone-test/10.100.100.28:22181 from apache.giraph.zk.ZooKeeperManager. Is there a server/environment I can execute the integration tests from?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1036 Support self-loop...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-170608607
  
    Please do run integration tests locally and see if everything passes. Paste your `BUILD SUCCESS` output. Then request a VOTE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---