You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marvin King (JIRA)" <ji...@codehaus.org> on 2006/07/07 05:42:23 UTC

[jira] Created: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

consider the artifact classifier when checking for duplicated artifacts
-----------------------------------------------------------------------

         Key: MWAR-58
         URL: http://jira.codehaus.org/browse/MWAR-58
     Project: Maven 2.x War Plugin
        Type: New Feature

    Reporter: Marvin King


see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-58?page=all ]

John Tolentino updated MWAR-58:
-------------------------------

    Attachment: MWAR-58-new.patch

Merged with current svn code (mostly affected by MWAR-59).

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58-new.patch, MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-58?page=all ]

Brett Porter updated MWAR-58:
-----------------------------

    Fix Version:     (was: 2.1)
                 2.0.2

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>          Key: MWAR-58
>          URL: http://jira.codehaus.org/browse/MWAR-58
>      Project: Maven 2.x War Plugin
>         Type: New Feature

>     Versions: 2.1
>     Reporter: Marvin King
>     Assignee: Marvin King
>      Fix For: 2.0.2

>
> Original Estimate: 1 hour
>         Remaining: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "Marvin King (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-58?page=all ]

Marvin King updated MWAR-58:
----------------------------

               Version: 2.1
           Fix Version: 2.1
    Remaining Estimate: 1 hour
     Original Estimate: 1 hour

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>          Key: MWAR-58
>          URL: http://jira.codehaus.org/browse/MWAR-58
>      Project: Maven 2.x War Plugin
>         Type: New Feature

>     Versions: 2.1
>     Reporter: Marvin King
>     Assignee: Marvin King
>      Fix For: 2.1

>
> Original Estimate: 1 hour
>         Remaining: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-58?page=all ]

Elliot Metsger updated MWAR-58:
-------------------------------

    Attachment: MWAR-58.patch

Please consider the attached patch (MWAR-58.patch).  This should fix the issue!

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-58?page=all ]

John Tolentino closed MWAR-58.
------------------------------

    Resolution: Fixed

Test cases done. Elliot Metsger, you can still submit your test cases if you want.

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58-new.patch, MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-58?page=comments#action_79084 ] 
            
John Tolentino commented on MWAR-58:
------------------------------------

I assume this haven't been applied yet. I'll look into this and write some test cases if it doesn't have any. Same goes with MWAR-59.

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-58?page=comments#action_79352 ] 
            
John Tolentino commented on MWAR-58:
------------------------------------

Elliot Metsger: Please use the patch I've attached here in creating your test cases. I've already merged it with MWAR-59 (which is already committed to svn). I'll do some tests as well. More tests the better.

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58-new.patch, MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-58?page=comments#action_76758 ] 
            
Elliot Metsger commented on MWAR-58:
------------------------------------

Note that the patch attached to this issue will need to be merged with the patch attached to MWAR-59

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-58?page=comments#action_79342 ] 
            
John Tolentino commented on MWAR-58:
------------------------------------

Yes. Please provide test cases if you can. Would greatly demonstrate the use case for the functionality you want added. This is for a portlet right?

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-58?page=comments#action_79360 ] 
            
John Tolentino commented on MWAR-58:
------------------------------------

This got resolved with the fix to MWAR-59. They both use getClassifier() in resolving the default final name. Need some test case though to prove this works for this scenario (duplicate artifacts).

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58-new.patch, MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "Marvin King (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-58?page=all ]

Marvin King updated MWAR-58:
----------------------------

    Assignee:     (was: Marvin King)

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>             Fix For: 2.0.2
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-58) consider the artifact classifier when checking for duplicated artifacts

Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-58?page=comments#action_79299 ] 
            
Elliot Metsger commented on MWAR-58:
------------------------------------

No it hasn't been applied - am waiting anxiously for the 2.0.2 release - I'd like to use the <targetPath> functionality in the Apache Pluto project, but don't want to have a dependency on a 2.0.2-SNAPSHOT war plugin :)

If you want I can take a stab at the test cases -

> consider the artifact classifier when checking for duplicated artifacts
> -----------------------------------------------------------------------
>
>                 Key: MWAR-58
>                 URL: http://jira.codehaus.org/browse/MWAR-58
>             Project: Maven 2.x War Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>            Reporter: Marvin King
>         Assigned To: John Tolentino
>             Fix For: 2.0.2
>
>         Attachments: MWAR-58.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> see http://www.nabble.com/-m2--war-plugin%2C-ignores-classifier-in-dependency-tf1903970.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira