[GitHub] [flink] yuchen-ecnu commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

[GitBox <gi...@apache.org>]

yuchen-ecnu commented on code in PR #21498:
URL: https://github.com/apache/flink/pull/21498#discussion_r1051818487


##########
docs/layouts/shortcodes/generated/cluster_configuration.html:
##########
@@ -70,7 +70,7 @@
         </tr>
         <tr>
             <td><h5>cluster.thread-dump.stacktrace-max-depth</h5></td>
-            <td style="word-wrap: break-word;">8</td>
+            <td style="word-wrap: break-word;">24</td>

Review Comment:
   Hi @1996fanrui , @Myasuka.
   
   I think such a deep call stack might not be required for most scenarios, and in our experience so far 24 seems to be a value that can cover most cases. 
   
   In my opinion, to balance the performance of the Rest API and analysis experience, we can consider setting up a deeper call stack with the parameters provided by Flink for such a job.
   
   https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/config/#cluster-thread-dump-stacktrace-max-depth



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org