You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/12 11:37:07 UTC

[I] [Studio][Bug] Prevent data source mutations before the initial list is ready [rocketmq-dashboard]

Aias00 opened a new issue, #2012:
URL: https://github.com/apache/rocketmq-dashboard/issues/2012

   ## Problem
   
   The Metrics data source tab starts `listDataSources()` on mount, but the **Add data source** action remains enabled while that request is pending.
   
   A user can create a data source before the initial list resolves. The create response is first appended to local state, but the late initial list response then unconditionally calls `setDataSources(sources)` and removes the newly created row from the UI.
   
   ## Reproduction
   
   1. Open Settings > Data sources and keep `listDataSources()` pending.
   2. Open the create modal and create a new data source successfully.
   3. Resolve the original list request with the pre-create snapshot.
   
   The success notification is shown, then the newly created row disappears.
   
   ## Expected behavior
   
   - Data source mutations must not start until the initial list snapshot is ready, or list responses must be reconciled with completed mutations.
   - The smallest fix should disable the create entry while the initial list is loading.
   - Add a deferred-promise regression test proving that a stale initial snapshot cannot overwrite a completed creation.
   
   ## Scope
   
   Metrics data source settings UI and focused frontend tests only.
   
   ## Track
   
   Track 1 / AI-Native unified control plane.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Prevent data source mutations before the initial list is ready [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #2012:
URL: https://github.com/apache/rocketmq-dashboard/issues/2012#issuecomment-5349549807

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Prevent data source mutations before the initial list is ready [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #2012: [Studio][Bug] Prevent data source mutations before the initial list is ready
URL: https://github.com/apache/rocketmq-dashboard/issues/2012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Prevent data source mutations before the initial list is ready [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2012:
URL: https://github.com/apache/rocketmq-dashboard/issues/2012#issuecomment-5266587005

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   Verified against `rocketmq-studio` branch: `web/src/pages/settings/index.tsx` (lines 300-313, 375-380).
   
   **Root Cause:** The initial `listDataSources()` is async. If a user creates a data source before the initial list resolves, `handleSubmit` mutates the stale local array (`[...previous, saved]`). When the initial load later resolves, it overwrites the mutation and the newly created data source disappears from the UI.
   
   **Impact:** Data Sources settings page — created data sources can silently vanish if the initial load is slow.
   
   **Severity:** Medium — race condition between initial load and create mutation.
   
   An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager-bot*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org