You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by icesmartjuan <gi...@git.apache.org> on 2018/07/22 04:25:23 UTC
[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui
GitHub user icesmartjuan opened a pull request:
https://github.com/apache/incubator-griffin/pull/366
GRIFFIN-185 - Feature/download ui
GRIFFIN-185 - Feature/download ui
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/icesmartjuan/incubator-griffin feature/download_ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/366.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #366
----
commit 5b9f07980f21fab7c40033a0a76682fa0bbf82d0
Author: Li, Juan <su...@...>
Date: 2018-07-17T13:31:23Z
add home page link under user setting
commit 0cc51bc300b74957f51fb48e6a4b0a2702a29638
Author: Li, Juan <su...@...>
Date: 2018-07-20T15:47:13Z
[Service] download missRecord service part
commit f1da2d557eb1ba34d316b3680df28db1f07872e5
Author: Li, Juan <su...@...>
Date: 2018-07-22T04:16:57Z
Refine service
commit 6e1ace4bfa2afbc09f73f815ca44238e7efeffc2
Author: Li, Juan <su...@...>
Date: 2018-07-22T04:23:44Z
UI part for feature of downloading miss record sample
----
---
[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-griffin/pull/366
---
[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/366#discussion_r204282850
--- Diff: service/src/main/java/org/apache/griffin/core/util/FSUtil.java ---
@@ -177,4 +177,23 @@ private static void checkHDFSConf() {
}
}
+ public static String getFirstMissRecordPath(String hdfsDir) throws Exception{
+ List<FileStatus> fileList = listFileStatus(hdfsDir);
+ for(int i=0; i<fileList.size();i++){
+ if(fileList.get(i).getPath().toUri().toString().toLowerCase().contains("missrecord")){
+ return fileList.get(i).getPath().toUri().toString();
+ }
+ }
+ return null;
--- End diff --
Is it okay to return `null`? Because it seems it can be used in `isFileExists` method, and there is no null checking.
Please let me know if I'm thinking wrong. Thanks.
---
[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui
Posted by icesmartjuan <gi...@git.apache.org>.
Github user icesmartjuan commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/366#discussion_r204635343
--- Diff: service/src/main/java/org/apache/griffin/core/util/FSUtil.java ---
@@ -177,4 +177,23 @@ private static void checkHDFSConf() {
}
}
+ public static String getFirstMissRecordPath(String hdfsDir) throws Exception{
+ List<FileStatus> fileList = listFileStatus(hdfsDir);
+ for(int i=0; i<fileList.size();i++){
+ if(fileList.get(i).getPath().toUri().toString().toLowerCase().contains("missrecord")){
+ return fileList.get(i).getPath().toUri().toString();
+ }
+ }
+ return null;
--- End diff --
good idea, thanks, I changed null to empty string
---