You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by ma...@apache.org on 2020/11/24 21:59:02 UTC

[incubator-nuttx] 02/06: Revert "arch: xtensa: Fix the pause handler for SMP"

This is an automated email from the ASF dual-hosted git repository.

masayuki pushed a commit to branch revert-2348-fix_pause_handler_for_smp
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 04602f0168dfd4f73d01ec2d60270506a327f51e
Author: Masayuki Ishikawa <ma...@gmail.com>
AuthorDate: Wed Nov 25 06:58:49 2020 +0900

    Revert "arch: xtensa: Fix the pause handler for SMP"
    
    This reverts commit 1914aac05f5b29e4fc54b143f3c461154efde96f.
---
 arch/xtensa/src/common/xtensa_cpupause.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/arch/xtensa/src/common/xtensa_cpupause.c b/arch/xtensa/src/common/xtensa_cpupause.c
index 0d7c486..5b59200 100644
--- a/arch/xtensa/src/common/xtensa_cpupause.c
+++ b/arch/xtensa/src/common/xtensa_cpupause.c
@@ -192,18 +192,7 @@ void xtensa_pause_handler(void)
 
   if (spin_islocked(&g_cpu_paused[cpu]))
     {
-      /* NOTE: up_cpu_paused() needs to be executed in a critical section
-       * to ensure that this CPU holds g_cpu_irqlock. However, adding
-       * a critical section in up_cpu_paused() is not a good idea,
-       * because it is also called in enter_critical_section() to break
-       * a deadlock
-       */
-
-      irqstate_t flags = enter_critical_section();
-
       up_cpu_paused(cpu);
-
-      leave_critical_section(flags);
     }
 }