[GitHub] [flink] ljz2051 commented on a diff in pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable

["ljz2051 (via GitHub)" <gi...@apache.org>]

ljz2051 commented on code in PR #23376:
URL: https://github.com/apache/flink/pull/23376#discussion_r1322333661


##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBPriorityQueueSetFactory.java:
##########
@@ -52,7 +52,9 @@
 public class RocksDBPriorityQueueSetFactory implements PriorityQueueSetFactory {
 
     /** Default cache size per key-group. */
-    @VisibleForTesting static final int DEFAULT_CACHES_SIZE = 128; // TODO make this configurable
+    @VisibleForTesting static final int DEFAULT_CACHES_SIZE = 128;
+
+    private final int cacheSize;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org