[jira] [Commented] (PHOENIX-5881) Port MaxLookbackAge logic to 5.x

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179258#comment-17179258 ] 

Hadoop QA commented on PHOENIX-5881:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13009983/PHOENIX-5881.v2.patch
  against master branch at commit .
  ATTACHMENT ID: 13009983

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 12 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            //In HBase 2.0-2.2, we can't see Puts behind Deletes even on lookback / SCN queries. Starting in 2.3 we can
+            int putBehindDeleteMarkerCount = HbaseCompatCapabilities.isLookbackBeyondDeletesSupported() ? 1 :0;
+        props.put(QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB, Long.toString(0));
+        props.put(CompatBaseScannerRegionObserver.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY, Integer.toString(MAX_LOOKBACK_AGE));
+            assertRowHasExpectedValueAtSCN(getUrl(), dataTableSelectSql, afterInsertSCN, firstValue);
+            assertRowHasExpectedValueAtSCN(getUrl(), indexTableSelectSql, afterInsertSCN, firstValue);
+            conn.createStatement().execute("upsert into " + tableName + " values ('a', 'ab', 'abc', 'abcd')");
+            conn.createStatement().execute("upsert into " + tableName + " values ('b', 'bc', 'bcd', 'bcde')");
+                                         String dataTableFullName, String indexTableFullName) throws SQLException {
+        IndexToolIT.assertExplainPlan(false, actualExplainPlan, dataTableFullName, indexTableFullName);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT

Test results: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/23//testReport/
Code Coverage results: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/23//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/23//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/23//console

This message is automatically generated.

> Port MaxLookbackAge logic to 5.x
> --------------------------------
>
>                 Key: PHOENIX-5881
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5881
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Blocker
>             Fix For: 5.1.0
>
>         Attachments: PHOENIX-5881.v1.patch, PHOENIX-5881.v2.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> PHOENIX-5645 wasn't included in the master (5.x) branch because an HBase 2.x change prevented the logic from being useful in the case of deletes, since HBase 2.x no longer allows us to show deleted cells on an SCN query before the point of deletion. Unfortunately, PHOENIX-5645 wound up requiring a lot of follow-up work in the IndexTool and IndexScrutinyTool to deal with its implications, and because of that, the 4.x and 5.x codebases around indexes have diverged a good bit. 
> This work item is to get them back in sync, even though the behavior in the face of deletes will be somewhat different, and so most likely some tests will have to be changed or Ignored. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)