You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/30 00:12:22 UTC

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16898: Sparse int64 Large tensor support

access2rohit commented on a change in pull request #16898: Sparse int64 Large tensor support
URL: https://github.com/apache/incubator-mxnet/pull/16898#discussion_r361880525
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -643,14 +643,14 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int storage_type,
 
 MXNET_DLL int MXNDArrayCreateSparseEx64(int storage_type,
                                         const int64_t *shape,
-                                        int ndim,
+                                        uint32_t ndim,
 
 Review comment:
   > Isn't ndim type always int? why change it here?
   
   keeping it consistent with 32bit version: https://github.com/apache/incubator-mxnet/pull/16898/files#diff-0ce80a2c739b88d1b42356fc2aff2630L633
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services