You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 14:31:35 UTC
[GitHub] [flink-connector-elasticsearch] deadwind4 commented on a diff in pull request #23: [FLINK-28428][connectors/elasticsearch][docs][docs-zh] Fix example and Chinese translations
deadwind4 commented on code in PR #23:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/23#discussion_r914913295
##########
docs/content/docs/connectors/datastream/elasticsearch.md:
##########
@@ -226,17 +226,60 @@ To use fault tolerant Elasticsearch Sinks, checkpointing of the topology needs t
{{< tabs "d00d1e93-4844-40d7-b0ec-9ec37e73145e" >}}
{{< tab "Java" >}}
+
+Elasticsearch 6:
+```java
+final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+env.enableCheckpointing(5000); // checkpoint every 5000 msecs
+
+Elasticsearch6SinkBuilder sinkBuilder = new Elasticsearch6SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
Review Comment:
Whether this commit changes an error doc file? Should we change the English doc but change the Chinese doc? https://github.com/apache/flink-connector-elasticsearch/commit/3c9430593d9d61254b63a66234d8dba9c269060b
##########
docs/content/docs/connectors/datastream/elasticsearch.md:
##########
@@ -226,17 +226,60 @@ To use fault tolerant Elasticsearch Sinks, checkpointing of the topology needs t
{{< tabs "d00d1e93-4844-40d7-b0ec-9ec37e73145e" >}}
{{< tab "Java" >}}
+
+Elasticsearch 6:
+```java
+final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+env.enableCheckpointing(5000); // checkpoint every 5000 msecs
+
+Elasticsearch6SinkBuilder sinkBuilder = new Elasticsearch6SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
Review Comment:
Whether this commit https://github.com/apache/flink-connector-elasticsearch/commit/3c9430593d9d61254b63a66234d8dba9c269060b changes an error doc file? Should we change the English doc but change the Chinese doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org