[GitHub] [wicket] martin-g commented on a change in pull request #382: WICKET-6688 add RFC and replace eval with DOM eval

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #382: WICKET-6688 add RFC and replace eval with DOM eval
URL: https://github.com/apache/wicket/pull/382#discussion_r322738353
 
 

 ##########
 File path: wicket-core/src/main/java/org/apache/wicket/page/PartialPageUpdate.java
 ##########
 @@ -657,34 +747,11 @@ public void render(HeaderItem item)
 				item = ((IWrappedHeaderItem) item).getWrapped();
 			}
 
-			if (item instanceof OnLoadHeaderItem)
-			{
-				if (!wasItemRendered(item))
-				{
-					PartialPageUpdate.this.appendJavaScript(((OnLoadHeaderItem) item).getJavaScript());
-					markItemRendered(item);
-				}
-			}
-			else if (item instanceof OnEventHeaderItem)
+			if (item instanceof OnLoadHeaderItem || item instanceof OnEventHeaderItem || item instanceof OnDomReadyHeaderItem)
 			{
 				if (!wasItemRendered(item))
 				{
-					PartialPageUpdate.this.appendJavaScript(((OnEventHeaderItem) item).getCompleteJavaScript());
-					markItemRendered(item);
-				}
-			}
-			else if (item instanceof OnDomReadyHeaderItem)
-			{
-				if (!wasItemRendered(item))
-				{
-					if (priorityHeaderItem != null)
 
 Review comment:
   Why the special handling of `priorityHeaderItem` is removed ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services