You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/06/12 14:02:06 UTC
DO NOT REPLY [Bug 39709] - [PATCH] Preview Panel not Window
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39709>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39709
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Keywords| |PatchAvailable
Resolution|WORKSFORME |
Summary|Preview Panel not Window |[PATCH] Preview Panel not
| |Window
------- Additional Comments From jeremias@apache.org 2006-06-12 12:02 -------
I've looked at the patch and think it's probably an improvement since it removes
AWT/Swing-dependant things from AWTRenderer. However, I'm not happy with the
name "ProgressListener" for the new interface. The methods setInfo() and
reload() don't really match that name. I think the whole AWT/Previewer thing has
grown over time and might profit from a general overhaul. The control flow is
very complicated by now. But I don't have time for that. To have an baic example
on how to use the PreviewPanel would also be very good. There has been demand
for that on fop-users. But I have other priorities ATM. I've locally applied the
patch, formatted the code and removed tab characters, so I'm ready to commit.
But I'd like additional feedback from another committer before I do that.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.