You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Kent Tong (JIRA)" <ta...@jakarta.apache.org> on 2006/12/28 17:48:20 UTC
[jira] Created: (TAPESTRY-1218) URL to dojo.js is not escaped
URL to dojo.js is not escaped
-----------------------------
Key: TAPESTRY-1218
URL: http://issues.apache.org/jira/browse/TAPESTRY-1218
Project: Tapestry
Issue Type: Bug
Components: XHR/dhtml/Ajax
Affects Versions: 4.1.1
Environment: WinXP. FireFox 2.0.
Reporter: Kent Tong
The AjaxShellDelegate generates code like:
<script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
but the & is not escaped. It should be:
<script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466336 ]
Jesse Kuhnert commented on TAPESTRY-1218:
-----------------------------------------
Are you guys sure about this? AjaxShellDelegate is just calling IAsset.buildURL() , which in turn calls AssetService.getLink() which uses all of the normal tapestry URL encoding resources to properly encode url's.
The end result that I see with friendly urls turned off is the first example that Kent shows, which is correct. If it were actually rendered as & the browser would correctly detect this to be an escape symbol and ignore it instead of using it as a valid character to implement the http protocol for query parameters.
Am I missing something?
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Richard Pitt (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494327 ]
Richard Pitt commented on TAPESTRY-1218:
----------------------------------------
For the record, this seems to be a general bug with all references to dojo resources, and is stopping us using HtmlUnit to test our tapestry application.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466484 ]
Jesse Kuhnert commented on TAPESTRY-1218:
-----------------------------------------
I did make an attempt at changing this yesterday but couldn't find an easy solution to whatever the problem is. (seeing as how it works in all known browsers and all)
If someone feels like fixing it they are more than welcome to, but I am probably not going to look at it again for a while.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Kuhnert updated TAPESTRY-1218:
------------------------------------
Fix Version/s: 4.1.2
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466349 ]
Jesse Kuhnert commented on TAPESTRY-1218:
-----------------------------------------
Yeah, but I don't think that's where we disagree. . Even if you do "view page source" on one of these JIRA pages you'll find that & symbols in href url query sections are visually seen as & - which is exactly how AjaxShellDelegate renders the symbols. If you actually saw the character string rendered in html source as "&" the url would be invalid.
So, again....I'm not seeing what is broken here.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Kent Tong (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466609 ]
Kent Tong commented on TAPESTRY-1218:
-------------------------------------
Well, the impact is that all T4.1 generated pages are broken as indicated by the w3c HTML validator (http://validator.w3.org).
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466342 ]
Andreas Andreou commented on TAPESTRY-1218:
-------------------------------------------
we all see the first example, but according to
http://www.w3.org/TR/html4/appendix/notes.html#h-B.2.2 and
http://www.htmlhelp.com/tools/validator/problems.html#amp
the second is the correct way...
I remember we had fixed this in 4.0.x - don't know how it reappeared.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Kuhnert resolved TAPESTRY-1218.
-------------------------------------
Resolution: Won't Fix
As no one has volunteered to do anything about this I'm closing it out.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Kent Tong (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466625 ]
Kent Tong commented on TAPESTRY-1218:
-------------------------------------
A quick search in Google with "w3c validator government policy" shows that the Canada government requires every one of its web sites be validated (http://www.apt.gc.ca/dProcClausesE.asp?Id=576). Anyone doing work for them has to comply.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461625 ]
Andreas Andreou commented on TAPESTRY-1218:
-------------------------------------------
Note: one has to disable friendly urls to see this
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494331 ]
Jesse Kuhnert commented on TAPESTRY-1218:
-----------------------------------------
Sure - as I've said before....As soon as someone gives me a solution that works I'll be happy to add it in.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466618 ]
Jesse Kuhnert commented on TAPESTRY-1218:
-----------------------------------------
I'm not sure how much of an impact that is. How many people run their apps inside the w3c validator?
If something were broken in an actual web browser I would be more concerned, but as it stands now I've made a first pass at "fixing" it but have not been able to yet so again should say that if anyone feels strongly about it they are free to give it a go but I'm too busy to play to the petty w3c validator gods right now.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Richard Pitt (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494346 ]
Richard Pitt commented on TAPESTRY-1218:
----------------------------------------
EngineServiceLink line 226 defines the separator: sep = "&";
I don't know if this code needs to sometimes escape the character and sometimes not.
If not then this should fix it: sep = "&";
Here is the stack trace:
EngineServiceLink.addParameters(StringBuffer) line: 226
EngineServiceLink.constructURL(StringBuffer, String, boolean) line: 187
EngineServiceLink.getURL(String, boolean) line: 140
EngineServiceLink.getURL() line: 135
PrivateAsset.buildURL() line: 72
AjaxShellDelegate.render(IMarkupWriter, IRequestCycle) line: 91
$Shell_136(Shell).renderComponent(IMarkupWriter, IRequestCycle) line: 109
$Shell_136(AbstractComponent).render(IMarkupWriter, IRequestCycle) line: 710
DefaultResponseBuilder.render(IMarkupWriter, IRender, IRequestCycle) line: 174
$Home_106(BaseComponent).renderComponent(IMarkupWriter, IRequestCycle) line: 92
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Posted by "Kent Tong (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466438 ]
Kent Tong commented on TAPESTRY-1218:
-------------------------------------
I am not sure if I am following you. I just viewed the source of this jira page, the URLs are indeed showing & which is the way it should be.
> URL to dojo.js is not escaped
> -----------------------------
>
> Key: TAPESTRY-1218
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
> Project: Tapestry
> Issue Type: Bug
> Components: XHR/dhtml/Ajax
> Affects Versions: 4.1.1
> Environment: WinXP. FireFox 2.0.
> Reporter: Kent Tong
> Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
> <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html should be used in the render() method in AjaxShellDelegate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org