[jira] [Commented] (OFBIZ-4427) Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during compilation

["Paul Foxworthy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107352#comment-13107352 ] 

Paul Foxworthy commented on OFBIZ-4427:
---------------------------------------

I like the principle, but the current implementation specifically refuses to even log a warning for commonly used classes like Number and DateTime. A comment says this is to avoid "flooding" the log. See https://fisheye6.atlassian.com/browse/~br=trunk/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/ObjectType.java?r=1076384#to774 . For other classes the logging severity level was reduced from warning to verbose, presumably again because of the volume of log entries.
Could someone get a number on how many places are affected before we decide how to proceed?

> Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during compilation
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4427
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4427
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>              Labels: UtilValidate.isEmpty
>             Fix For: SVN trunk
>
>
> Hence we need tp remove the UtilValidate.isEmpty(Object) method and provide methods that accept explicit types.  
> Scripting languages should use a facade class that provides methods for working with generic Objects or providing default behaviors.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira