You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2018/08/02 19:23:54 UTC
Review Request 68169: SENTRY-2332: Load hadoop default configuration
when starting sentry service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68169/
-----------------------------------------------------------
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Bugs: SENTRY-2332
https://issues.apache.org/jira/browse/SENTRY-2332
Repository: sentry
Description
-------
When sentry service starts we instantiate a new configuration object. But we force it to not load default resources like 'core-site.xml', 'core-default.xml' because of which those configurations are not being consumed
Diffs
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java 7c827ca22
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestNotificationHandlerInvoker.java 92f3f8bad
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java 3475624e3
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java 3fe5b6a58
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java 6a84b0521
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java d33ae2608
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java 40ac9941a
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java 21aa7f997
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java c5caa1336
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java 1c44b269c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java e0b584c63
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSentryServer.java 28c3102da
Diff: https://reviews.apache.org/r/68169/diff/1/
Testing
-------
$ mvn -f sentry-service/sentry-service-server/pom.xml test
$ mvn -f sentry-tests/sentry-tests-hive/pom.xml test
All tests passed
Thanks,
Arjun Mishra
Re: Review Request 68169: SENTRY-2332: Load hadoop default
configuration when starting sentry service
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68169/#review206823
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Aug. 2, 2018, 7:23 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68169/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 7:23 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2332
> https://issues.apache.org/jira/browse/SENTRY-2332
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When sentry service starts we instantiate a new configuration object. But we force it to not load default resources like 'core-site.xml', 'core-default.xml' because of which those configurations are not being consumed
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java 7c827ca22
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestNotificationHandlerInvoker.java 92f3f8bad
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java 3475624e3
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java 3fe5b6a58
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java 6a84b0521
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java d33ae2608
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java 40ac9941a
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java 21aa7f997
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java c5caa1336
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java 1c44b269c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java e0b584c63
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSentryServer.java 28c3102da
>
>
> Diff: https://reviews.apache.org/r/68169/diff/1/
>
>
> Testing
> -------
>
> $ mvn -f sentry-service/sentry-service-server/pom.xml test
> $ mvn -f sentry-tests/sentry-tests-hive/pom.xml test
>
> All tests passed
>
>
> Thanks,
>
> Arjun Mishra
>
>