You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Meredith (Jira)" <ji...@apache.org> on 2021/01/14 04:12:00 UTC
[jira] [Created] (CASSANDRA-16385) Correctly serialize all request
responses - CASSANDRA-15946 followup
Jon Meredith created CASSANDRA-16385:
----------------------------------------
Summary: Correctly serialize all request responses - CASSANDRA-15946 followup
Key: CASSANDRA-16385
URL: https://issues.apache.org/jira/browse/CASSANDRA-16385
Project: Cassandra
Issue Type: Improvement
Components: Test/dtest/java
Reporter: Jon Meredith
Assignee: Jon Meredith
When receiving a message, a 4.0 dtest instance reserializes messages to pass them through the dtest message filtering.
The 4.0 internode messaging refactor does not expect to have to re-serialize response
messages, so the workaround in CASSANDRA-15946 was just to register the ReadResponse serializer for all REQUEST_RESPONSE messages, however request response is used for other responses too.
I'm attaching a patch that demonstrates the issue by adding a simple Paxos upgrade test to generate a PrepareResponse message that crashes the ReadResponse serializer, then reverts CASSANDRA-15946 and re-users the messaging service serialization method that checks the request callback if a serializer is not defined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org