[jira] [Commented] (CLOUDSTACK-8375) Marvin - Code improvement - VCenter port groups verification

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490880#comment-14490880 ] 

ASF GitHub Bot commented on CLOUDSTACK-8375:
--------------------------------------------

GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/155

    CLOUDSTACK-8375: Marvin - Code Improvement  - Verifying VCenter port groups corresponding to traffic types in a zone

    1. Reducing complexity of function "verifyVCenterPortGroups". Earlier it had two for loops, now it has only one. The parameter zone_list has been replaced with "zone" because we map a VCenter to a zone and not multiple zones.
    
    2. Correcting the logic used to generate expected port group names for public traffic. The port group with network rate as defined in "network.throttling.rate" is created only when a VM is deployed and its network uses a public IP from public IP range dedicated to public traffic.
    
    3. Adding a wrapper function for verifying guest traffic port groups which creates vcenter connection object and calls verifyVCenterPortGroups function with GUEST_TRAFFIC as parameter. This function is very handy and can be called from any networking test case with only a single line call. This separates the additional logic from test case and moves it to this wrapper function.
    
    
    The code has been tested against multiple types of Vmware deployments including mixture tagged and untagged traffic types and mixed switches (SVS and DVS).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 1159089ca51ac44d41e565a2e0356741fe06b8ac
Author: Gaurav Aradhye <ga...@clogeny.com>
Date:   2015-04-11T09:07:28Z

    CLOUDSTACK-8375: Marvin - Code Improvement  - related to verifying VCenter port groups corresponding to traffic types in a zone

----


> Marvin - Code improvement - VCenter port groups verification
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8375
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8375
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>    Affects Versions: Future
>            Reporter: Gaurav Aradhye
>            Assignee: Gaurav Aradhye
>             Fix For: Future
>
>
> Improving the code related to VCenter port groups modification.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)