[jira] [Comment Edited] (CB-9636) Plugin should detect at runtime iOS 8 and use of file:// url and present an error

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738374#comment-14738374 ] 

Shazron Abdullah edited comment on CB-9636 at 9/10/15 8:23 AM:
---------------------------------------------------------------

The check should be done when the external webview has been chosen, and is not the default webview. in newCordovaView


was (Author: shazron):
The check should be done at this point, after all the plugins have loaded:
https://github.com/apache/cordova-ios/blob/0f571e354f4f2e8dc52dbf1723f0340cecd9bab9/CordovaLib/Classes/Public/CDVViewController.m#L302

> Plugin should detect at runtime iOS 8 and use of file:// url and present an error
> ---------------------------------------------------------------------------------
>
>                 Key: CB-9636
>                 URL: https://issues.apache.org/jira/browse/CB-9636
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: cordova-ios-4.0.x
>
> Check whether it's a file url and iOS 8, and use loadHTMLString to present an error instead (and NSLog it).
> This is unfortunate and shouldn't happen but we need to catch it nonetheless.
> The WebView engine load will fail if these conditions are fulfilled:
> 1. iOS 8 
> 2. file:// url
> 3. current WebView engine is a WKWebView
> This determination should be delegated to the WebView engine itself. There needs to be another method in the CDVWebViewEngineProtocol -- canLoadRequest:(NSURLRequest*)
> If the WebViewEngine cannot load the request, we fall back to the UIWebView engine. This might cause a UI glitch that is undesirable when we need to replace WebView engines -- this assumption needs to be tested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org