You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2023/01/17 21:14:06 UTC
[GitHub] [isis] myroch opened a new pull request, #1371: ISIS-3328: HTML Documentation Service based on the domain model
myroch opened a new pull request, #1371:
URL: https://github.com/apache/isis/pull/1371
We have created new documentation service which creates the HTML documentation based on the menu and the domain model. Very similar to the sitemap, but in HTML, so the end user can directly show it together with autogenerated description.
I've migrated it into the latest version, I've just hasn't been able to test it. At least it worked fine in ISIS M7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
Posted by GitBox <gi...@apache.org>.
andi-huber commented on PR #1371:
URL: https://github.com/apache/isis/pull/1371#issuecomment-1386429923
While there is nothing wrong with the code, I don't think we'll merge it into the framework. Mainly because I think the docs created are suitable to provide a documentation blueprint, but in the general case, not enough to be presented to the end-user.
This opinionated of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] myroch commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
Posted by GitBox <gi...@apache.org>.
myroch commented on PR #1371:
URL: https://github.com/apache/isis/pull/1371#issuecomment-1396602530
Hallo @andi-huber @danhaywood
Thank you very much for the merging. As I said, I wasn't able to test it in the newest version, have you tried then?
Andi, it looks actually very good in our project, we present it to the end-user. I'm curious what is wrong on your side, maybe lack of the description in the annotations? Otherwise we can still fix it.
Anyway thanks guys, my code is mainly based on @yourfrienddhruv 's work, so he should be honored instead.
Regards,
m.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] danhaywood commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
Posted by GitBox <gi...@apache.org>.
danhaywood commented on PR #1371:
URL: https://github.com/apache/isis/pull/1371#issuecomment-1396509572
Thanks for this contribution, @myroch . Andi and I discussed it a bit more, actually we think we will bring this in, we think it's a nice idea. So, thanks! @andi-huber - can you do the honours?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
Posted by GitBox <gi...@apache.org>.
andi-huber commented on PR #1371:
URL: https://github.com/apache/isis/pull/1371#issuecomment-1386461365
For now, let's keep this PR open for further discussion and ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber merged pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
Posted by GitBox <gi...@apache.org>.
andi-huber merged PR #1371:
URL: https://github.com/apache/isis/pull/1371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
Posted by GitBox <gi...@apache.org>.
andi-huber commented on PR #1371:
URL: https://github.com/apache/isis/pull/1371#issuecomment-1396607319
I'll see that I add this new menu bar entry to our demo app. I might do some tiny refactoring.
And as I said I like the idea, but don't particularly like the programmatic HTML creation code. But as discussed with Dan, we can always improve that later if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org