[GitHub] [kvrocks-website] tisonkun opened a new pull request, #114: chore: after graduation

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun opened a new pull request, #114:
URL: https://github.com/apache/kvrocks-website/pull/114

   The release and verify guide need a review and rework.
   
   cc @git-hulk @PragmaTwice 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kvrocks-website] tisonkun merged pull request #114: chore: after graduation

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun merged PR #114:
URL: https://github.com/apache/kvrocks-website/pull/114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kvrocks-website] tisonkun commented on a diff in pull request #114: chore: after graduation

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #114:
URL: https://github.com/apache/kvrocks-website/pull/114#discussion_r1238592286


##########
src/components/Releases/index.tsx:
##########
@@ -14,23 +26,19 @@ type ReleaseData = {
     signature: string,
 }
 
-function createReleaseData(index: number, version: string): ReleaseData {
-    var vtag = `${version}-incubating`
-    // Drop the incubating suffix for releases after graduation
-    if (index >= 4) {
-        vtag = `${version}`
-    }
-    const archive = `https://downloads.apache.org/kvrocks/${version}/apache-kvrocks-${vtag}-src.tar.gz`
+function createReleaseData(version: string, vtag?: string): ReleaseData {
+    const fixedVTag = vtag ?? version;

Review Comment:
   I noticed that the downloads link are use `2.4.0` so we do have two concepts here. But later we can populate only the `version` field and if we add a `semver` dependency, we can do a test against version string (anyway, not depend on array index).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org