You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/02 23:10:57 UTC
[jira] [Commented] (FLUME-949) Collapse PollableSink into Sink
interface.
[ https://issues.apache.org/jira/browse/FLUME-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199276#comment-13199276 ]
jiraposter@reviews.apache.org commented on FLUME-949:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3739/
-----------------------------------------------------------
Review request for Flume and Arvind Prabhakar.
Summary
-------
I've collapsed PollableSink into Sink interface and fixed all other classes. I'm wondering whether it would make sense to also collapse PollableSinkRunner into SinkRunner class?
This addresses bug FLUME-949.
https://issues.apache.org/jira/browse/FLUME-949
Diffs
-----
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/PollableSink.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/Sink.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/PollableSinkRunner.java 1239790
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 1239790
/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 1239790
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1239790
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 1239790
/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java 1239790
Diff: https://reviews.apache.org/r/3739/diff
Testing
-------
mvn test passes correctly for entire flume-ng project
Thanks,
Jarek
> Collapse PollableSink into Sink interface.
> ------------------------------------------
>
> Key: FLUME-949
> URL: https://issues.apache.org/jira/browse/FLUME-949
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0
> Reporter: Arvind Prabhakar
> Assignee: Jarek Jarcec Cecho
> Priority: Critical
>
> See the discussion thread:
> http://markmail.org/thread/e5rfcm2mwg54ofjo
> Summary: We do not have any non-pollable sink types and in order to keep the infrastructure and implementation simple, we want to standardize on the pollable sink model. Hence it makes sense to remove the explicit notion of PollableSink and move the process() method directly into the Sink definition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira