[GitHub] [spark] cloud-fan commented on a change in pull request #26297: [DO NOT MERGE]

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26297: [DO NOT MERGE]
URL: https://github.com/apache/spark/pull/26297#discussion_r340757675
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Expressions.java
 ##########
 @@ -82,8 +82,10 @@ public static NamedReference column(String name) {
    * @return a logical bucket transform with name "bucket"
    */
   public static Transform bucket(int numBuckets, String... columns) {
-    return LogicalExpressions.bucket(numBuckets,
-        JavaConverters.asScalaBuffer(Arrays.asList(columns)).toSeq());
+    NamedReference[] references = Arrays.stream(columns)
 
 Review comment:
   I'll send another for these related changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org