You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/19 11:39:50 UTC

[GitHub] [airflow] mik-laj commented on pull request #7450: [AIRFLOW-6829][WIP] Auto-apply apply_default

mik-laj commented on pull request #7450:
URL: https://github.com/apache/airflow/pull/7450#issuecomment-712098622


   I finished this PR, but there is a minor problem if we want to be compatible with Airflow 1.10 and still release packages for Airflow. 1.10. 
   
   The `airflow.utils.decorators.apply_defaults` decorator displays deprecation warnings (it's okey).  The problem is that we should update all operators and delete invocation of this decorator so that these warnings will not appear. But we cannot do that if we want to keep release backport packages, because in Airflow 1.10, this decorator is still required. We also can't add this decorator with Bowler, because Bowler could get lost in the class hierarchy and it's too complex so I can't trust him.
   
   I can see several solutions:
   - Merge unchanged and messages will be displayed in Airflow 2.0 alpha and Breeze. 
   - Add a bowler refactor for the provider packages for Airflow 2.0 that will delete this decorator
   - Conditionally display warnings for Breeze. Once the user is in the breeze then they will not see the warning.
   
   @ashb @kaxil @potiuk WDYT? It would be nice if we could include these changes into the next alpha.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org