[GitHub] [hive] pvary commented on a change in pull request #1797: HIVE-24541: add config option for default storage handler class

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1797:
URL: https://github.com/apache/hive/pull/1797#discussion_r551330709



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -1991,6 +1991,10 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
         "Default file format for CREATE TABLE statement applied to managed tables only. External tables will be \n" +
         "created with format specified by hive.default.fileformat. Leaving this null will result in using hive.default.fileformat \n" +
         "for all tables."),
+    HIVEDEFAULTSTORAGEHANDLER("hive.default.storage.handler.class", "",

Review comment:
       Could be please use underscores to separate names? I understand that the ones before and after are not using them, but currently the underscore is the "standard" 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org